Clean up some includes and comments in TAP test scripts

michaelpq · michaelpq · commit 1409eade9f20 · 2022-07-07T10:13:01.000+09:00
A few tests included File::Path::rmtree without using it, and a comment related to the segment size for replication slot limits was wrong. Author: Pavel Borisov, Bharath Rupireddy Reviewed-by: Maxim Orlov Discussion: https://postgr.es/m/CALj2ACU4-aNLX=DrUM8F7QDwynJKzYRiqOj_33NhnGbhDs5-kQ@mail.gmail.com
diff --git a/src/bin/pg_verifybackup/t/007_wal.pl b/src/bin/pg_verifybackup/t/007_wal.pl
@@ -5,7 +5,6 @@
 
 use strict;
 use warnings;
-use File::Path qw(rmtree);
 use PostgreSQL::Test::Cluster;
 use PostgreSQL::Test::Utils;
 use Test::More;
diff --git a/src/test/recovery/t/004_timeline_switch.pl b/src/test/recovery/t/004_timeline_switch.pl
@@ -4,7 +4,6 @@
 # Test for timeline switch
 use strict;
 use warnings;
-use File::Path qw(rmtree);
 use PostgreSQL::Test::Cluster;
 use PostgreSQL::Test::Utils;
 use Test::More;
diff --git a/src/test/recovery/t/019_replslot_limit.pl b/src/test/recovery/t/019_replslot_limit.pl
@@ -9,8 +9,6 @@
 
 use PostgreSQL::Test::Utils;
 use PostgreSQL::Test::Cluster;
-
-use File::Path qw(rmtree);
 use Test::More;
 use Time::HiRes qw(usleep);
 
@@ -429,7 +427,7 @@ sub advance_wal
 {
 	my ($node, $n) = @_;
 
-	# Advance by $n segments (= (16 * $n) MB) on primary
+	# Advance by $n segments (= (wal_segment_size * $n) bytes) on primary.
 	for (my $i = 0; $i < $n; $i++)
 	{
 		$node->safe_psql('postgres',

Original file line number	Diff line number	Diff line change
`@@ -9,8 +9,6 @@`
`9`	`9`
`10`	`10`	`use PostgreSQL::Test::Utils;`
`11`	`11`	`use PostgreSQL::Test::Cluster;`
`12`		`-`
`13`		`-use File::Path qw(rmtree);`
`14`	`12`	`use Test::More;`
`15`	`13`	`use Time::HiRes qw(usleep);`
`16`	`14`
`@@ -429,7 +427,7 @@ sub advance_wal`
`429`	`427`	`{`
`430`	`428`	`my ($node, $n) = @_;`
`431`	`429`
`432`		`- # Advance by $n segments (= (16 * $n) MB) on primary`
	`430`	`+ # Advance by $n segments (= (wal_segment_size * $n) bytes) on primary.`
`433`	`431`	`for (my $i = 0; $i < $n; $i++)`
`434`	`432`	`{`
`435`	`433`	`$node->safe_psql('postgres',`