Trivial dead code removal: in makeObjectName(), name1 must be non-NULL

Neil Conway · Neil Conway · commit 141e878bc3af · 2005-06-21T00:35:05.000Z
(due to the preceding strlen(), for example), so we needn't recheck this
before invoking pg_mbcliplen().

Per Coverity static analysis performed by EnterpriseDB.
diff --git a/src/backend/commands/indexcmds.c b/src/backend/commands/indexcmds.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/backend/commands/indexcmds.c,v 1.131 2005/05/06 17:24:53 tgl Exp $
+ *	  $PostgreSQL: pgsql/src/backend/commands/indexcmds.c,v 1.132 2005/06/21 00:35:05 neilc Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -760,8 +760,7 @@ makeObjectName(const char *name1, const char *name2, const char *label)
 			name2chars--;
 	}
 
-	if (name1)
-		name1chars = pg_mbcliplen(name1, name1chars, name1chars);
+	name1chars = pg_mbcliplen(name1, name1chars, name1chars);
 	if (name2)
 		name2chars = pg_mbcliplen(name2, name2chars, name2chars);
 

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $PostgreSQL: pgsql/src/backend/commands/indexcmds.c,v 1.131 2005/05/06 17:24:53 tgl Exp $`
	`11`	`+ * $PostgreSQL: pgsql/src/backend/commands/indexcmds.c,v 1.132 2005/06/21 00:35:05 neilc Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -760,8 +760,7 @@ makeObjectName(const char name1, const char name2, const char *label)`
`760`	`760`	`name2chars--;`
`761`	`761`	`}`
`762`	`762`
`763`		`- if (name1)`
`764`		`- name1chars = pg_mbcliplen(name1, name1chars, name1chars);`
	`763`	`+ name1chars = pg_mbcliplen(name1, name1chars, name1chars);`
`765`	`764`	`if (name2)`
`766`	`765`	`name2chars = pg_mbcliplen(name2, name2chars, name2chars);`
`767`	`766`