to_char(): prevent accesses beyond the allocated buffer

bmomjian · bmomjian · commit 1628a0bbfa2e · 2015-02-02T10:00:49.000-05:00
Previously very long field masks for floats could access memory beyond the existing buffer allocated to hold the result. Reported by Andres Freund and Peter Geoghegan. Backpatch to all supported versions. Security: CVE-2015-0241
diff --git a/src/backend/utils/adt/formatting.c b/src/backend/utils/adt/formatting.c
@@ -4428,7 +4428,9 @@ NUM_numpart_to_char(NUMProc *Np, int id)
 					Np->num_in = TRUE;
 				}
 			}
-			++Np->number_p;
+			/* do no exceed string length */
+			if (*Np->number_p)
+				++Np->number_p;
 		}
 
 		end = Np->num_count + (Np->out_pre_spaces ? 1 : 0) + (IS_DECIMAL(Np->Num) ? 1 : 0);

Original file line number	Diff line number	Diff line change
`@@ -4428,7 +4428,9 @@ NUM_numpart_to_char(NUMProc *Np, int id)`
`4428`	`4428`	`Np->num_in = TRUE;`
`4429`	`4429`	`}`
`4430`	`4430`	`}`
`4431`		`- ++Np->number_p;`
	`4431`	`+ /* do no exceed string length */`
	`4432`	`+ if (*Np->number_p)`
	`4433`	`+ ++Np->number_p;`
`4432`	`4434`	`}`
`4433`	`4435`
`4434`	`4436`	`end = Np->num_count + (Np->out_pre_spaces ? 1 : 0) + (IS_DECIMAL(Np->Num) ? 1 : 0);`