System neglected to complain about ungrouped variables passed to

tglsfdc · tglsfdc · commit 164caa3951a8 · 2000-09-25T18:09:28.000Z
sublinks when outer query contained aggregates but no GROUP clause.
diff --git a/src/backend/optimizer/plan/planner.c b/src/backend/optimizer/plan/planner.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/backend/optimizer/plan/planner.c,v 1.89 2000/09/12 21:06:54 tgl Exp $
+ *	  $Header: /cvsroot/pgsql/src/backend/optimizer/plan/planner.c,v 1.90 2000/09/25 18:09:28 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -184,7 +184,7 @@ subquery_planner(Query *parse, double tuple_fraction)
 		parse->qual = SS_process_sublinks(parse->qual);
 		parse->havingQual = SS_process_sublinks(parse->havingQual);
 
-		if (parse->groupClause != NIL)
+		if (parse->groupClause != NIL || parse->hasAggs)
 		{
 
 			/*

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $Header: /cvsroot/pgsql/src/backend/optimizer/plan/planner.c,v 1.89 2000/09/12 21:06:54 tgl Exp $`
	`11`	`+ * $Header: /cvsroot/pgsql/src/backend/optimizer/plan/planner.c,v 1.90 2000/09/25 18:09:28 tgl Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -184,7 +184,7 @@ subquery_planner(Query *parse, double tuple_fraction)`
`184`	`184`	`parse->qual = SS_process_sublinks(parse->qual);`
`185`	`185`	`parse->havingQual = SS_process_sublinks(parse->havingQual);`
`186`	`186`
`187`		`- if (parse->groupClause != NIL)`
	`187`	`+ if (parse->groupClause != NIL \|\| parse->hasAggs)`
`188`	`188`	`{`
`189`	`189`
`190`	`190`	`/*`