> Rod Taylor <rbt@rbt.ca> writes:

bmomjian · bmomjian · commit 187e86517402 · 2003-07-25T19:27:06.000Z
&gt; &gt; It seems that readline() on my system (FreeBSD 4.8) isn't declared to
&gt; &gt; take the prompt as a const.  Thus, remove const from gets_interactive()
&gt; &gt; to remove the warning.
&gt;
&gt; I think it would be a lot cleaner to just put a cast to char * into the
&gt; readline call (with a note about why).

Ok.. that works.

I must say it's a little strange being able to take a constant and say
its no longer constant anymore -- but I suppose it's no different than
defining then undefining pre-processor constants.

Rod Taylor &lt;rbt@rbt.ca&gt;
diff --git a/src/bin/psql/input.c b/src/bin/psql/input.c
@@ -3,7 +3,7 @@
  *
  * Copyright 2000 by PostgreSQL Global Development Group
  *
- * $Header: /cvsroot/pgsql/src/bin/psql/input.c,v 1.24 2003/07/23 08:47:39 petere Exp $
+ * $Header: /cvsroot/pgsql/src/bin/psql/input.c,v 1.25 2003/07/25 19:27:06 momjian Exp $
  */
 #include "postgres_fe.h"
 #include "input.h"
@@ -86,7 +86,8 @@ gets_interactive(const char *prompt)
 	static char *prev_hist = NULL;
 
 	if (useReadline)
-		s = readline(prompt);
+		/* On some platforms, readline is declared as readline(char *) */
+		s = readline((char *) prompt);
 	else
 		s = gets_basic(prompt);
 
