Don't force SQL_ASCII/no-locale for installcheck in vcregress.pl

adunstan · adunstan · commit 18f2f8b8b02c · 2023-02-26T06:48:41.000-05:00
It's been this way for a very long time, but it appears to have been
masking an issue that only manifests with different settings. Therefore,
run the tests in the installation's default encoding/locale.

Backpatch to all live branches.
diff --git a/src/tools/msvc/vcregress.pl b/src/tools/msvc/vcregress.pl
@@ -164,9 +164,7 @@ sub installcheck_internal
 		"--dlpath=.",
 		"--bindir=../../../$Config/psql",
 		"--schedule=${schedule}_schedule",
-		"--max-concurrent-tests=20",
-		"--encoding=SQL_ASCII",
-		"--no-locale");
+		"--max-concurrent-tests=20");
 	push(@args, $maxconn) if $maxconn;
 	push(@args, @EXTRA_REGRESS_OPTS);
 	system(@args);
