Add comment about checkpoint panic behavior during shutdown, per

tglsfdc · tglsfdc · commit 19d127548cf7 · 2005-04-23T18:49:54.000Z
suggestion from Qingqing Zhou.
diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/xlog.c
@@ -7,7 +7,7 @@
  * Portions Copyright (c) 1996-2005, PostgreSQL Global Development Group
  * Portions Copyright (c) 1994, Regents of the University of California
  *
- * $PostgreSQL: pgsql/src/backend/access/transam/xlog.c,v 1.187 2005/04/17 03:04:29 momjian Exp $
+ * $PostgreSQL: pgsql/src/backend/access/transam/xlog.c,v 1.188 2005/04/23 18:49:54 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -4925,7 +4925,10 @@ CreateCheckPoint(bool shutdown, bool force)
 	 *
 	 * This I/O could fail for various reasons.  If so, we will fail to
 	 * complete the checkpoint, but there is no reason to force a system
-	 * panic.  Accordingly, exit critical section while doing it.
+	 * panic.  Accordingly, exit critical section while doing it.  (If
+	 * we are doing a shutdown checkpoint, we probably *should* panic ---
+	 * but that will happen anyway because we'll still be inside the
+	 * critical section established by ShutdownXLOG.)
 	 */
 	END_CRIT_SECTION();
 

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@`
`7`	`7`	`* Portions Copyright (c) 1996-2005, PostgreSQL Global Development Group`
`8`	`8`	`* Portions Copyright (c) 1994, Regents of the University of California`
`9`	`9`	`*`
`10`		`- * $PostgreSQL: pgsql/src/backend/access/transam/xlog.c,v 1.187 2005/04/17 03:04:29 momjian Exp $`
	`10`	`+ * $PostgreSQL: pgsql/src/backend/access/transam/xlog.c,v 1.188 2005/04/23 18:49:54 tgl Exp $`
`11`	`11`	`*`
`12`	`12`	`*-------------------------------------------------------------------------`
`13`	`13`	`*/`
`@@ -4925,7 +4925,10 @@ CreateCheckPoint(bool shutdown, bool force)`
`4925`	`4925`	`*`
`4926`	`4926`	`* This I/O could fail for various reasons. If so, we will fail to`
`4927`	`4927`	`* complete the checkpoint, but there is no reason to force a system`
`4928`		`- * panic. Accordingly, exit critical section while doing it.`
	`4928`	`+ * panic. Accordingly, exit critical section while doing it. (If`
	`4929`	`+ * we are doing a shutdown checkpoint, we probably should panic ---`
	`4930`	`+ * but that will happen anyway because we'll still be inside the`
	`4931`	`+ * critical section established by ShutdownXLOG.)`
`4929`	`4932`	`*/`
`4930`	`4933`	`END_CRIT_SECTION();`
`4931`	`4934`