Restore some comments lost during 15732b3

alvherre · alvherre · commit 1a3e82a7f94e · 2014-01-03T13:22:03.000-03:00
Michael Paquier
diff --git a/src/backend/catalog/index.c b/src/backend/catalog/index.c
@@ -1446,9 +1446,11 @@ index_drop(Oid indexId, bool concurrent)
 
 		/*
 		 * Now we must wait until no running transaction could be using the
-		 * index for a query. Note we do not need to worry about xacts that
-		 * open the table for reading after this point; they will see the
-		 * index as invalid when they open the relation.
+		 * index for a query.  Use AccessExclusiveLock here to check for
+		 * running transactions that hold locks of any kind on the table.
+		 * Note we do not need to worry about xacts that open the table for
+		 * reading after this point; they will see the index as invalid when
+		 * they open the relation.
 		 *
 		 * Note: the reason we use actual lock acquisition here, rather than
 		 * just checking the ProcArray and sleeping, is that deadlock is
diff --git a/src/backend/commands/indexcmds.c b/src/backend/commands/indexcmds.c
@@ -651,9 +651,10 @@ DefineIndex(IndexStmt *stmt,
 	 * for an overview of how this works)
 	 *
 	 * Now we must wait until no running transaction could have the table open
-	 * with the old list of indexes. Note we do not need to worry about xacts
-	 * that open the table for writing after this point; they will see the new
-	 * index when they open it.
+	 * with the old list of indexes.  Use ShareLock to consider running
+	 * transactions that hold locks that permit writing to the table.  Note we
+	 * do not need to worry about xacts that open the table for writing after
+	 * this point; they will see the new index when they open it.
 	 *
 	 * Note: the reason we use actual lock acquisition here, rather than just
 	 * checking the ProcArray and sleeping, is that deadlock is possible if

Original file line number	Diff line number	Diff line change
`@@ -651,9 +651,10 @@ DefineIndex(IndexStmt *stmt,`
`651`	`651`	`* for an overview of how this works)`
`652`	`652`	`*`
`653`	`653`	`* Now we must wait until no running transaction could have the table open`
`654`		`- * with the old list of indexes. Note we do not need to worry about xacts`
`655`		`- * that open the table for writing after this point; they will see the new`
`656`		`- * index when they open it.`
	`654`	`+ * with the old list of indexes. Use ShareLock to consider running`
	`655`	`+ * transactions that hold locks that permit writing to the table. Note we`
	`656`	`+ * do not need to worry about xacts that open the table for writing after`
	`657`	`+ * this point; they will see the new index when they open it.`
`657`	`658`	`*`
`658`	`659`	`* Note: the reason we use actual lock acquisition here, rather than just`
`659`	`660`	`* checking the ProcArray and sleeping, is that deadlock is possible if`