Add comment on why deadlock detection error messages only prints numbers.

bmomjian · bmomjian · commit 1c8302cab32b · 2007-04-20T20:15:52.000Z
diff --git a/src/backend/storage/lmgr/deadlock.c b/src/backend/storage/lmgr/deadlock.c
@@ -12,7 +12,7 @@
  *
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/backend/storage/lmgr/deadlock.c,v 1.46 2007/03/03 19:32:54 neilc Exp $
+ *	  $PostgreSQL: pgsql/src/backend/storage/lmgr/deadlock.c,v 1.47 2007/04/20 20:15:52 momjian Exp $
  *
  *	Interface:
  *
@@ -836,6 +836,8 @@ PrintLockQueue(LOCK *lock, const char *info)
  * Append a description of a lockable object to buf.
  *
  * XXX probably this should be exported from lmgr.c or some such place.
+ * Ideally we would print names for the numeric values, but that requires
+ * getting locks on system tables, which might cause problems.
  */
 static void
 DescribeLockTag(StringInfo buf, const LOCKTAG *lock)

Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,7 @@`
`12`	`12`	`*`
`13`	`13`	`*`
`14`	`14`	`* IDENTIFICATION`
`15`		`- * $PostgreSQL: pgsql/src/backend/storage/lmgr/deadlock.c,v 1.46 2007/03/03 19:32:54 neilc Exp $`
	`15`	`+ * $PostgreSQL: pgsql/src/backend/storage/lmgr/deadlock.c,v 1.47 2007/04/20 20:15:52 momjian Exp $`
`16`	`16`	`*`
`17`	`17`	`* Interface:`
`18`	`18`	`*`
`@@ -836,6 +836,8 @@ PrintLockQueue(LOCK lock, const char info)`
`836`	`836`	`* Append a description of a lockable object to buf.`
`837`	`837`	`*`
`838`	`838`	`* XXX probably this should be exported from lmgr.c or some such place.`
	`839`	`+ * Ideally we would print names for the numeric values, but that requires`
	`840`	`+ * getting locks on system tables, which might cause problems.`
`839`	`841`	`*/`
`840`	`842`	`static void`
`841`	`843`	`DescribeLockTag(StringInfo buf, const LOCKTAG *lock)`