Suppress compiler warning in a different way, per Alvaro.

bmomjian · bmomjian · commit 1d2a185eaedf · 2009-01-06T03:15:51.000Z
diff --git a/src/backend/access/common/reloptions.c b/src/backend/access/common/reloptions.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/backend/access/common/reloptions.c,v 1.14 2009/01/06 02:44:17 momjian Exp $
+ *	  $PostgreSQL: pgsql/src/backend/access/common/reloptions.c,v 1.15 2009/01/06 03:15:51 momjian Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -667,7 +667,7 @@ parse_one_reloption(relopt_value *option, char *text_str, int text_len,
 {
 	char	   *value;
 	int			value_len;
-	bool		parsed = true;  /* quiet compiler */
+	bool		parsed;
 	bool		nofree = false;
 
 	if (option->isset && validate)
@@ -736,6 +736,7 @@ parse_one_reloption(relopt_value *option, char *text_str, int text_len,
 			break;
 		default:
 			elog(ERROR, "unsupported reloption type %d", option->gen->type);
+			parsed = true; /* quiet compiler */
 			break;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $PostgreSQL: pgsql/src/backend/access/common/reloptions.c,v 1.14 2009/01/06 02:44:17 momjian Exp $`
	`11`	`+ * $PostgreSQL: pgsql/src/backend/access/common/reloptions.c,v 1.15 2009/01/06 03:15:51 momjian Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -667,7 +667,7 @@ parse_one_reloption(relopt_value option, char text_str, int text_len,`
`667`	`667`	`{`
`668`	`668`	`char *value;`
`669`	`669`	`int value_len;`
`670`		`- bool parsed = true; /* quiet compiler */`
	`670`	`+ bool parsed;`
`671`	`671`	`bool nofree = false;`
`672`	`672`
`673`	`673`	`if (option->isset && validate)`
`@@ -736,6 +736,7 @@ parse_one_reloption(relopt_value option, char text_str, int text_len,`
`736`	`736`	`break;`
`737`	`737`	`default:`
`738`	`738`	`elog(ERROR, "unsupported reloption type %d", option->gen->type);`
	`739`	`+ parsed = true; /* quiet compiler */`
`739`	`740`	`break;`
`740`	`741`	`}`
`741`	`742`