Fix PQsetdbLogin() backward compatibility problem.

tatsuo-ishii · tatsuo-ishii · commit 1deb6e7d414f · 2000-12-22T07:59:32.000Z
If pghost == "" and pgport == "" then PQsetdbLogin() fails with a
error message:

 Is the postmaster running locally
        and accepting connections on Unix socket '/tmp/.s.PGSQL.0'?

I see many applications such as PHP fails due to this behavior.
Now if pgport == "", then it is assumed to be a DEF_PGPORT_STR. This
is the same behavior as the version prior 7.1.
diff --git a/src/interfaces/libpq/fe-connect.c b/src/interfaces/libpq/fe-connect.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/interfaces/libpq/fe-connect.c,v 1.155 2000/12/18 17:33:41 tgl Exp $
+ *	  $Header: /cvsroot/pgsql/src/interfaces/libpq/fe-connect.c,v 1.156 2000/12/22 07:59:32 ishii Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -438,7 +438,7 @@ PQsetdbLogin(const char *pghost, const char *pgport, const char *pgoptions,
 	else if ((tmp = getenv("PGHOST")) != NULL)
 		conn->pghost = strdup(tmp);
 
-	if (pgport == NULL)
+	if (pgport == NULL || pgport[0] == '\0')
 	{
 		if ((tmp = getenv("PGPORT")) == NULL)
 			tmp = DEF_PGPORT_STR;

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $Header: /cvsroot/pgsql/src/interfaces/libpq/fe-connect.c,v 1.155 2000/12/18 17:33:41 tgl Exp $`
	`11`	`+ * $Header: /cvsroot/pgsql/src/interfaces/libpq/fe-connect.c,v 1.156 2000/12/22 07:59:32 ishii Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -438,7 +438,7 @@ PQsetdbLogin(const char pghost, const char pgport, const char *pgoptions,`
`438`	`438`	`else if ((tmp = getenv("PGHOST")) != NULL)`
`439`	`439`	`conn->pghost = strdup(tmp);`
`440`	`440`
`441`		`- if (pgport == NULL)`
	`441`	`+ if (pgport == NULL \|\| pgport[0] == '\0')`
`442`	`442`	`{`
`443`	`443`	`if ((tmp = getenv("PGPORT")) == NULL)`
`444`	`444`	`tmp = DEF_PGPORT_STR;`