Fix inadequately-tested code path in tuplesort_skiptuples().

tglsfdc · tglsfdc · commit 1def747db68b · 2013-12-24T17:13:02.000-05:00
Per report from Jeff Davis.
diff --git a/src/backend/utils/sort/tuplesort.c b/src/backend/utils/sort/tuplesort.c
@@ -1725,6 +1725,8 @@ tuplesort_getdatum(Tuplesortstate *state, bool forward,
 bool
 tuplesort_skiptuples(Tuplesortstate *state, int64 ntuples, bool forward)
 {
+	MemoryContext oldcontext;
+
 	/*
 	 * We don't actually support backwards skip yet, because no callers need
 	 * it.	The API is designed to allow for that later, though.
@@ -1760,18 +1762,23 @@ tuplesort_skiptuples(Tuplesortstate *state, int64 ntuples, bool forward)
 			 * We could probably optimize these cases better, but for now it's
 			 * not worth the trouble.
 			 */
+			oldcontext = MemoryContextSwitchTo(state->sortcontext);
 			while (ntuples-- > 0)
 			{
 				SortTuple	stup;
 				bool		should_free;
 
 				if (!tuplesort_gettuple_common(state, forward,
 											   &stup, &should_free))
+				{
+					MemoryContextSwitchTo(oldcontext);
 					return false;
-				if (should_free)
+				}
+				if (should_free && stup.tuple)
 					pfree(stup.tuple);
 				CHECK_FOR_INTERRUPTS();
 			}
+			MemoryContextSwitchTo(oldcontext);
 			return true;
 
 		default:
