Mark argument of RegisterCustomRmgr() as const.

jeff-davis · jeff-davis · commit 1eda3ce80287 · 2022-11-15T16:01:35.000-08:00
diff --git a/doc/src/sgml/custom-rmgr.sgml b/doc/src/sgml/custom-rmgr.sgml
@@ -78,7 +78,7 @@ typedef struct RmgrData
  * developers. During development, use RM_EXPERIMENTAL_ID to avoid needlessly
  * reserving a new ID.
  */
-extern void RegisterCustomRmgr(RmgrId rmid, RmgrData *rmgr);
+extern void RegisterCustomRmgr(RmgrId rmid, const RmgrData *rmgr);
 </programlisting>
   <function>RegisterCustomRmgr</function> must be called from the
   extension module's <link linkend="xfunc-c-dynload">_PG_init</link> function.
diff --git a/src/backend/access/transam/rmgr.c b/src/backend/access/transam/rmgr.c
@@ -95,7 +95,7 @@ RmgrNotFound(RmgrId rmid)
  * reserving a new ID.
  */
 void
-RegisterCustomRmgr(RmgrId rmid, RmgrData *rmgr)
+RegisterCustomRmgr(RmgrId rmid, const RmgrData *rmgr)
 {
 	if (rmgr->rm_name == NULL || strlen(rmgr->rm_name) == 0)
 		ereport(ERROR, (errmsg("custom resource manager name is invalid"),
diff --git a/src/include/access/xlog_internal.h b/src/include/access/xlog_internal.h
@@ -362,7 +362,7 @@ extern PGDLLIMPORT RmgrData RmgrTable[];
 extern void RmgrStartup(void);
 extern void RmgrCleanup(void);
 extern void RmgrNotFound(RmgrId rmid);
-extern void RegisterCustomRmgr(RmgrId rmid, RmgrData *rmgr);
+extern void RegisterCustomRmgr(RmgrId rmid, const RmgrData *rmgr);
 
 #ifndef FRONTEND
 static inline bool
diff --git a/src/test/modules/test_custom_rmgrs/test_custom_rmgrs.c b/src/test/modules/test_custom_rmgrs/test_custom_rmgrs.c
@@ -51,7 +51,7 @@ void		testcustomrmgrs_redo(XLogReaderState *record);
 void		testcustomrmgrs_desc(StringInfo buf, XLogReaderState *record);
 const char *testcustomrmgrs_identify(uint8 info);
 
-static RmgrData testcustomrmgrs_rmgr = {
+static const RmgrData testcustomrmgrs_rmgr = {
 	.rm_name = TESTCUSTOMRMGRS_NAME,
 	.rm_redo = testcustomrmgrs_redo,
 	.rm_desc = testcustomrmgrs_desc,

Original file line number	Diff line number	Diff line change
`@@ -95,7 +95,7 @@ RmgrNotFound(RmgrId rmid)`
`95`	`95`	`* reserving a new ID.`
`96`	`96`	`*/`
`97`	`97`	`void`
`98`		`-RegisterCustomRmgr(RmgrId rmid, RmgrData *rmgr)`
	`98`	`+RegisterCustomRmgr(RmgrId rmid, const RmgrData *rmgr)`
`99`	`99`	`{`
`100`	`100`	`if (rmgr->rm_name == NULL \|\| strlen(rmgr->rm_name) == 0)`
`101`	`101`	`ereport(ERROR, (errmsg("custom resource manager name is invalid"),`