Add missing reset of need_initialization in reloptions code.

tglsfdc · tglsfdc · commit 1f44a313bdff · 2010-03-11T21:47:19.000Z
This resulted in useless extra work during every call of parseRelOptions,
but no bad effects other than that.  Noted by Alvaro.
diff --git a/src/backend/access/common/reloptions.c b/src/backend/access/common/reloptions.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/backend/access/common/reloptions.c,v 1.33 2010/02/26 02:00:32 momjian Exp $
+ *	  $PostgreSQL: pgsql/src/backend/access/common/reloptions.c,v 1.34 2010/03/11 21:47:19 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -244,8 +244,9 @@ static void
 initialize_reloptions(void)
 {
 	int			i;
-	int			j = 0;
+	int			j;
 
+	j = 0;
 	for (i = 0; boolRelOpts[i].gen.name; i++)
 		j++;
 	for (i = 0; intRelOpts[i].gen.name; i++)
@@ -302,6 +303,9 @@ initialize_reloptions(void)
 
 	/* add a list terminator */
 	relOpts[j] = NULL;
+
+	/* flag the work is complete */
+	need_initialization = false;
 }
 
 /*

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $PostgreSQL: pgsql/src/backend/access/common/reloptions.c,v 1.33 2010/02/26 02:00:32 momjian Exp $`
	`11`	`+ * $PostgreSQL: pgsql/src/backend/access/common/reloptions.c,v 1.34 2010/03/11 21:47:19 tgl Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -244,8 +244,9 @@ static void`
`244`	`244`	`initialize_reloptions(void)`
`245`	`245`	`{`
`246`	`246`	`int i;`
`247`		`- int j = 0;`
	`247`	`+ int j;`
`248`	`248`
	`249`	`+ j = 0;`
`249`	`250`	`for (i = 0; boolRelOpts[i].gen.name; i++)`
`250`	`251`	`j++;`
`251`	`252`	`for (i = 0; intRelOpts[i].gen.name; i++)`
`@@ -302,6 +303,9 @@ initialize_reloptions(void)`
`302`	`303`
`303`	`304`	`/* add a list terminator */`
`304`	`305`	`relOpts[j] = NULL;`
	`306`	`+`
	`307`	`+ /* flag the work is complete */`
	`308`	`+ need_initialization = false;`
`305`	`309`	`}`
`306`	`310`
`307`	`311`	`/*`