Fix copy-paste bug in 12f3867 triggering an assert after a write error

anarazel · anarazel · commit 21d7c05a5cf7 · 2023-04-07T01:02:46.000-07:00
The same condition accidentally was copied to both branches. Manual testing
confirms that otherwise the error recovery path works fine.

Found while reviewing the logical-decoding-on-standby patch.
diff --git a/src/backend/storage/buffer/bufmgr.c b/src/backend/storage/buffer/bufmgr.c
@@ -5199,7 +5199,7 @@ AbortBufferIO(Buffer buf)
 	}
 	else
 	{
-		Assert(!(buf_state & BM_DIRTY));
+		Assert(buf_state & BM_DIRTY);
 		UnlockBufHdr(buf_hdr, buf_state);
 
 		/* Issue notice if this is not the first failure... */

Original file line number	Diff line number	Diff line change
`@@ -5199,7 +5199,7 @@ AbortBufferIO(Buffer buf)`
`5199`	`5199`	`}`
`5200`	`5200`	`else`
`5201`	`5201`	`{`
`5202`		`- Assert(!(buf_state & BM_DIRTY));`
	`5202`	`+ Assert(buf_state & BM_DIRTY);`
`5203`	`5203`	`UnlockBufHdr(buf_hdr, buf_state);`
`5204`	`5204`
`5205`	`5205`	`/* Issue notice if this is not the first failure... */`