Skip to content

Commit 2336f84

Browse files
committed
Reword comment for clarity
Reported by Masahiko Sawada Discussion: https://postgr.es/m/CAD21AoB+ycZ2z-4Ye=6MfQ_r0aV5r6cvVPw4kOyPdp6bHqQoBQ@mail.gmail.com
1 parent e88928c commit 2336f84

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/backend/replication/logical/snapbuild.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1116,9 +1116,9 @@ SnapBuildProcessRunningXacts(SnapBuild *builder, XLogRecPtr lsn, xl_running_xact
11161116
* so, because we only need to do it for catalog transactions since we
11171117
* only ever look at those.
11181118
*
1119-
* NB: Because of that xmax can be lower than xmin, because we only
1120-
* increase xmax when a catalog modifying transaction commits. While odd
1121-
* looking, it's correct and actually more efficient this way since we hit
1119+
* NB: We only increase xmax when a catalog modifying transaction commits
1120+
* (see SnapBuildCommitTxn). Because of this, xmax can be lower than xmin,
1121+
* which looks odd but is correct and actually more efficient, since we hit
11221122
* fast paths in tqual.c.
11231123
*/
11241124
builder->xmin = running->oldestRunningXid;

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy