During parallel pg_dump, free commands from master

sfrost · sfrost · commit 234e4cf6e1ea · 2013-07-14T14:35:26.000-04:00
The command strings read by the child processes during parallel
pg_dump, after being read and handled, were not being free'd.
This patch corrects this relatively minor memory leak.

Leak found by the Coverity scanner.

Back patch to 9.3 where parallel pg_dump was introduced.
diff --git a/src/bin/pg_dump/parallel.c b/src/bin/pg_dump/parallel.c
@@ -922,6 +922,9 @@ WaitForCommands(ArchiveHandle *AH, int pipefd[2])
 			exit_horribly(modulename,
 						  "unrecognized command on communication channel: %s\n",
 						  command);
+
+		/* command was pg_malloc'd and we are responsible for free()ing it. */
+		free(command);
 	}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -922,6 +922,9 @@ WaitForCommands(ArchiveHandle *AH, int pipefd[2])`
`922`	`922`	`exit_horribly(modulename,`
`923`	`923`	`"unrecognized command on communication channel: %s\n",`
`924`	`924`	`command);`
	`925`	`+`
	`926`	`+ /* command was pg_malloc'd and we are responsible for free()ing it. */`
	`927`	`+ free(command);`
`925`	`928`	`}`
`926`	`929`	`}`
`927`	`930`