Update some obsolete comments.

tglsfdc · tglsfdc · commit 244dd95ce9d9 · 2017-03-26T11:36:46.000-04:00
Fix a few stray references to expression eval functions that don't
exist anymore or don't take the same input representation they used to.
diff --git a/src/backend/optimizer/util/clauses.c b/src/backend/optimizer/util/clauses.c
@@ -354,8 +354,8 @@ make_and_qual(Node *qual1, Node *qual2)
 }
 
 /*
- * Sometimes (such as in the input of ExecQual), we use lists of expression
- * nodes with implicit AND semantics.
+ * The planner frequently prefers to represent qualification expressions
+ * as lists of boolean expressions with implicit AND semantics.
  *
  * These functions convert between an AND-semantics expression list and the
  * ordinary representation of a boolean expression.
diff --git a/src/backend/utils/cache/relcache.c b/src/backend/utils/cache/relcache.c
@@ -4743,7 +4743,7 @@ RelationGetIndexExpressions(Relation relation)
  * RelationGetIndexPredicate -- get the index predicate for an index
  *
  * We cache the result of transforming pg_index.indpred into an implicit-AND
- * node tree (suitable for ExecQual).
+ * node tree (suitable for use in planning).
  * If the rel is not an index or has no predicate, we return NIL.
  * Otherwise, the returned tree is copied into the caller's memory context.
  * (We don't want to return a pointer to the relcache copy, since it could
diff --git a/src/pl/plpgsql/src/pl_exec.c b/src/pl/plpgsql/src/pl_exec.c
@@ -4759,7 +4759,7 @@ exec_assign_value(PLpgSQL_execstate *estate,
 				 * fixed-length array types we skip the assignment.  We can't
 				 * support assignment of a null entry into a fixed-length
 				 * array, either, so that's a no-op too.  This is all ugly but
-				 * corresponds to the current behavior of ExecEvalArrayRef().
+				 * corresponds to the current behavior of execExpr*.c.
 				 */
 				if (arrayelem->arraytyplen > 0 &&		/* fixed-length array? */
 					(oldarrayisnull || isNull))

Original file line number	Diff line number	Diff line change
`@@ -354,8 +354,8 @@ make_and_qual(Node qual1, Node qual2)`
`354`	`354`	`}`
`355`	`355`
`356`	`356`	`/*`
`357`		`- * Sometimes (such as in the input of ExecQual), we use lists of expression`
`358`		`- * nodes with implicit AND semantics.`
	`357`	`+ * The planner frequently prefers to represent qualification expressions`
	`358`	`+ * as lists of boolean expressions with implicit AND semantics.`
`359`	`359`	`*`
`360`	`360`	`* These functions convert between an AND-semantics expression list and the`
`361`	`361`	`* ordinary representation of a boolean expression.`
Original file line number	Diff line number	Diff line change
`@@ -4743,7 +4743,7 @@ RelationGetIndexExpressions(Relation relation)`
`4743`	`4743`	`* RelationGetIndexPredicate -- get the index predicate for an index`
`4744`	`4744`	`*`
`4745`	`4745`	`* We cache the result of transforming pg_index.indpred into an implicit-AND`
`4746`		`- * node tree (suitable for ExecQual).`
	`4746`	`+ * node tree (suitable for use in planning).`
`4747`	`4747`	`* If the rel is not an index or has no predicate, we return NIL.`
`4748`	`4748`	`* Otherwise, the returned tree is copied into the caller's memory context.`
`4749`	`4749`	`* (We don't want to return a pointer to the relcache copy, since it could`