Don't superfluously materialize slot after DELETE from an FDW.

anarazel · anarazel · commit 253655116bb4 · 2019-02-28T14:54:12.000-08:00
Previously that was needed to safely store the table oid, but after b8d7174 that's not necessary anymore. Author: Andres Freund
diff --git a/src/backend/executor/nodeModifyTable.c b/src/backend/executor/nodeModifyTable.c
@@ -655,7 +655,6 @@ ExecDelete(ModifyTableState *mtstate,
 		 */
 		if (TTS_EMPTY(slot))
 			ExecStoreAllNullTuple(slot);
-		ExecMaterializeSlot(slot);
 
 		slot->tts_tableOid = RelationGetRelid(resultRelationDesc);
 	}

Original file line number	Diff line number	Diff line change
`@@ -655,7 +655,6 @@ ExecDelete(ModifyTableState *mtstate,`
`655`	`655`	`*/`
`656`	`656`	`if (TTS_EMPTY(slot))`
`657`	`657`	`ExecStoreAllNullTuple(slot);`
`658`		`- ExecMaterializeSlot(slot);`
`659`	`658`
`660`	`659`	`slot->tts_tableOid = RelationGetRelid(resultRelationDesc);`
`661`	`660`	`}`