Fix blatantly broken record_image_cmp() logic for pass-by-value fields.

tglsfdc · tglsfdc · commit 28858811472f · 2013-10-22T00:38:53.000-04:00
Doesn't anybody here pay attention to compiler warnings?
diff --git a/src/backend/utils/adt/rowtypes.c b/src/backend/utils/adt/rowtypes.c
@@ -1430,7 +1430,7 @@ record_image_cmp(FunctionCallInfo fcinfo)
 		 */
 		if (!nulls1[i1] || !nulls2[i2])
 		{
-			int			cmpresult;
+			int			cmpresult = 0;
 
 			if (nulls1[i1])
 			{

Original file line number	Diff line number	Diff line change
`@@ -1430,7 +1430,7 @@ record_image_cmp(FunctionCallInfo fcinfo)`
`1430`	`1430`	`*/`
`1431`	`1431`	`if (!nulls1[i1] \|\| !nulls2[i2])`
`1432`	`1432`	`{`
`1433`		`- int cmpresult;`
	`1433`	`+ int cmpresult = 0;`
`1434`	`1434`
`1435`	`1435`	`if (nulls1[i1])`
`1436`	`1436`	`{`