Bugfix. If toasted tuple containted NULLs, DataFill() was handed

Jan Wieck · Jan Wieck · commit 2a225ebf18af · 2000-07-06T18:22:45.000Z
a wrong pointer causing the bitmap overwriting the tuple header.

Jan
diff --git a/src/backend/access/heap/tuptoaster.c b/src/backend/access/heap/tuptoaster.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/backend/access/heap/tuptoaster.c,v 1.5 2000/07/03 23:09:19 wieck Exp $
+ *	  $Header: /cvsroot/pgsql/src/backend/access/heap/tuptoaster.c,v 1.6 2000/07/06 18:22:45 wieck Exp $
  *
  *
  * INTERFACE ROUTINES
@@ -619,7 +619,7 @@ toast_insert_or_update(Relation rel, HeapTuple newtup, HeapTuple oldtup)
 				toast_values,
 				toast_nulls,
 				&(newtup->t_data->t_infomask),
-				HeapTupleNoNulls(newtup) ? NULL : new_data);
+				has_nulls ? newtup->t_data->t_bits : NULL);
 
 		/* ----------
 		 * In the case we modified a previously modified tuple again,

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $Header: /cvsroot/pgsql/src/backend/access/heap/tuptoaster.c,v 1.5 2000/07/03 23:09:19 wieck Exp $`
	`11`	`+ * $Header: /cvsroot/pgsql/src/backend/access/heap/tuptoaster.c,v 1.6 2000/07/06 18:22:45 wieck Exp $`
`12`	`12`	`*`
`13`	`13`	`*`
`14`	`14`	`* INTERFACE ROUTINES`
`@@ -619,7 +619,7 @@ toast_insert_or_update(Relation rel, HeapTuple newtup, HeapTuple oldtup)`
`619`	`619`	`toast_values,`
`620`	`620`	`toast_nulls,`
`621`	`621`	`&(newtup->t_data->t_infomask),`
`622`		`- HeapTupleNoNulls(newtup) ? NULL : new_data);`
	`622`	`+ has_nulls ? newtup->t_data->t_bits : NULL);`
`623`	`623`
`624`	`624`	`/* ----------`
`625`	`625`	`* In the case we modified a previously modified tuple again,`