Silence pedantic compiler warning introduced in ce340e5

anarazel · anarazel · commit 2b7259f85572 · 2023-03-16T09:41:13.000-07:00
.../src/common/file_utils.c: In function ‘pg_pwrite_zeros’:
.../src/common/file_utils.c:543:9: warning: ‘static’ is not at beginning of declaration [-Wold-style-declaration]
  543 |         const static PGAlignedBlock zbuffer = {{0}};    /* worth BLCKSZ */
diff --git a/src/common/file_utils.c b/src/common/file_utils.c
@@ -540,7 +540,7 @@ pg_pwritev_with_retry(int fd, const struct iovec *iov, int iovcnt, off_t offset)
 ssize_t
 pg_pwrite_zeros(int fd, size_t size, off_t offset)
 {
-	const static PGAlignedBlock zbuffer = {{0}};	/* worth BLCKSZ */
+	static const PGAlignedBlock zbuffer = {{0}};	/* worth BLCKSZ */
 	void	   *zerobuf_addr = unconstify(PGAlignedBlock *, &zbuffer)->data;
 	struct iovec iov[PG_IOV_MAX];
 	size_t		remaining_size = size;

Original file line number	Diff line number	Diff line change
`@@ -540,7 +540,7 @@ pg_pwritev_with_retry(int fd, const struct iovec *iov, int iovcnt, off_t offset)`
`540`	`540`	`ssize_t`
`541`	`541`	`pg_pwrite_zeros(int fd, size_t size, off_t offset)`
`542`	`542`	`{`
`543`		`- const static PGAlignedBlock zbuffer = {{0}}; /* worth BLCKSZ */`
	`543`	`+ static const PGAlignedBlock zbuffer = {{0}}; /* worth BLCKSZ */`
`544`	`544`	`void zerobuf_addr = unconstify(PGAlignedBlock , &zbuffer)->data;`
`545`	`545`	`struct iovec iov[PG_IOV_MAX];`
`546`	`546`	`size_t remaining_size = size;`