Correct comment in Hot Standby nbtree handling

simonat2ndQuadrant · simonat2ndQuadrant · commit 2e54d88af137 · 2014-05-06T14:44:18.000+01:00
Logic is correct, matching handling of LP_DEAD elsewhere.
diff --git a/src/backend/access/nbtree/nbtxlog.c b/src/backend/access/nbtree/nbtxlog.c
@@ -714,11 +714,11 @@ btree_xlog_delete_get_latestRemovedXid(xl_btree_delete *xlrec)
 	UnlockReleaseBuffer(ibuffer);
 
 	/*
-	 * XXX If all heap tuples were LP_DEAD then we will be returning
-	 * InvalidTransactionId here, causing conflict for all HS transactions.
-	 * That should happen very rarely (reasoning please?). Also note that
-	 * caller can't tell the difference between this case and the fast path
-	 * exit above. May need to change that in future.
+	 * If all heap tuples were LP_DEAD then we will be returning
+	 * InvalidTransactionId here, which avoids conflicts. This matches
+	 * existing logic which assumes that LP_DEAD tuples must already be
+	 * older than the latestRemovedXid on the cleanup record that
+	 * set them as LP_DEAD, hence must already have generated a conflict.
 	 */
 	return latestRemovedXid;
 }
