Fix breakage introduced in pg_lsn_in()

petere · petere · commit 2e810508f6b0 · 2019-06-30T13:25:33.000+02:00
Using PG_RETURN_LSN() from non-fmgr pg_lsn_in_internal() happened to
work on some platforms, but should just be a plain "return".
diff --git a/src/backend/utils/adt/pg_lsn.c b/src/backend/utils/adt/pg_lsn.c
@@ -53,7 +53,7 @@ pg_lsn_in_internal(const char *str, bool *have_error)
 	off = (uint32) strtoul(str + len1 + 1, NULL, 16);
 	result = ((uint64) id << 32) | off;
 
-	PG_RETURN_LSN(result);
+	return result;
 }
 
 Datum

Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,7 @@ pg_lsn_in_internal(const char str, bool have_error)`
`53`	`53`	`off = (uint32) strtoul(str + len1 + 1, NULL, 16);`
`54`	`54`	`result = ((uint64) id << 32) \| off;`
`55`	`55`
`56`		`- PG_RETURN_LSN(result);`
	`56`	`+ return result;`
`57`	`57`	`}`
`58`	`58`
`59`	`59`	`Datum`