Remove ExecRemoveJunk(), which is no longer used anywhere.

tglsfdc · tglsfdc · commit 2e852e541c84 · 2011-02-21T21:41:08.000-05:00
This was a leftover from the pre-8.1 design of junkfilters.  It doesn't
seem to have any reason to live, since it's merely a combination of two
easy function calls, and not a well-designed combination at that (it
encourages callers to leak the result tuple).
diff --git a/src/backend/executor/execJunk.c b/src/backend/executor/execJunk.c
@@ -40,9 +40,9 @@
  *
  * Finally, when at the top level we get back a tuple, we can call
  * ExecFindJunkAttribute/ExecGetJunkAttribute to retrieve the values of the
- * junk attributes we are interested in, and ExecFilterJunk or ExecRemoveJunk
- * to remove all the junk attributes from a tuple. This new "clean" tuple is
- * then printed, inserted, or updated.
+ * junk attributes we are interested in, and ExecFilterJunk to remove all the
+ * junk attributes from a tuple.  This new "clean" tuple is then printed,
+ * inserted, or updated.
  *
  *-------------------------------------------------------------------------
  */
@@ -317,15 +317,3 @@ ExecFilterJunk(JunkFilter *junkfilter, TupleTableSlot *slot)
 	 */
 	return ExecStoreVirtualTuple(resultSlot);
 }
-
-/*
- * ExecRemoveJunk
- *
- * Convenience routine to generate a physical clean tuple,
- * rather than just a virtual slot.
- */
-HeapTuple
-ExecRemoveJunk(JunkFilter *junkfilter, TupleTableSlot *slot)
-{
-	return ExecCopySlotTuple(ExecFilterJunk(junkfilter, slot));
-}
diff --git a/src/include/executor/executor.h b/src/include/executor/executor.h
@@ -148,7 +148,6 @@ extern Datum ExecGetJunkAttribute(TupleTableSlot *slot, AttrNumber attno,
 					 bool *isNull);
 extern TupleTableSlot *ExecFilterJunk(JunkFilter *junkfilter,
 			   TupleTableSlot *slot);
-extern HeapTuple ExecRemoveJunk(JunkFilter *junkfilter, TupleTableSlot *slot);
 
 
 /*
