Fix invalid-parallel-jobs error message

sfrost · sfrost · commit 2ef6fe9cbae9 · 2017-01-09T23:09:29.000-05:00
Including the program name twice is not helpful:

-&gt; pg_dump -j -1
pg_dump: pg_dump: invalid number of parallel jobs

Correct by removing the progname from the exit_horribly() call used when
validating the number of parallel jobs.

Noticed while testing various pg_dump error cases.

Back-patch to 9.3 where parallel pg_dump was added.
diff --git a/src/bin/pg_dump/pg_dump.c b/src/bin/pg_dump/pg_dump.c
@@ -623,7 +623,7 @@ main(int argc, char **argv)
 		|| numWorkers > MAXIMUM_WAIT_OBJECTS
 #endif
 		)
-		exit_horribly(NULL, "%s: invalid number of parallel jobs\n", progname);
+		exit_horribly(NULL, "invalid number of parallel jobs\n");
 
 	/* Parallel backup only in the directory archive format so far */
 	if (archiveFormat != archDirectory && numWorkers > 1)

Original file line number	Diff line number	Diff line change
`@@ -623,7 +623,7 @@ main(int argc, char **argv)`
`623`	`623`	`\|\| numWorkers > MAXIMUM_WAIT_OBJECTS`
`624`	`624`	`#endif`
`625`	`625`	`)`
`626`		`- exit_horribly(NULL, "%s: invalid number of parallel jobs\n", progname);`
	`626`	`+ exit_horribly(NULL, "invalid number of parallel jobs\n");`
`627`	`627`
`628`	`628`	`/* Parallel backup only in the directory archive format so far */`
`629`	`629`	`if (archiveFormat != archDirectory && numWorkers > 1)`