Skip to content

Commit 2f657e4

Browse files
committed
More pg_upgrade relfilenode C comments added.
1 parent 3095643 commit 2f657e4

File tree

2 files changed

+9
-1
lines changed

2 files changed

+9
-1
lines changed

contrib/pg_upgrade/info.c

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,13 @@ create_rel_filename_map(const char *old_data, const char *new_data,
132132
new_cluster.tablespace_suffix, new_db->db_oid);
133133
}
134134

135+
/*
136+
* old_relfilenode might differ from pg_class.oid (and hence
137+
* new_relfilenode) because of CLUSTER, REINDEX, or VACUUM FULL.
138+
*/
135139
map->old_relfilenode = old_rel->relfilenode;
140+
141+
/* new_relfilenode will match old and new pg_class.oid */
136142
map->new_relfilenode = new_rel->relfilenode;
137143

138144
/* used only for logging and error reporing, old/new are identical */

contrib/pg_upgrade/pg_upgrade.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,9 @@
1919
* in a cluster, but they can diverge due to CLUSTER, REINDEX, or VACUUM
2020
* FULL. The new cluster will have matching pg_class.oid and
2121
* pg_class.relfilenode values and be based on the old oid value. This can
22-
* cause the old and new pg_class.relfilenode values to differ.
22+
* cause the old and new pg_class.relfilenode values to differ. In summary,
23+
* old and new pg_class.oid and new pg_class.relfilenode will have the
24+
* same value, and old pg_class.relfilenode might differ.
2325
*
2426
* We control all assignments of pg_type.oid because these oids are stored
2527
* in user composite type values.

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy