Silence minor compiler warnings.

tglsfdc · tglsfdc · commit 302612a6c74f · 2022-02-13T13:06:55.000-05:00
Depending on compiler version and optimization level, we might
get a complaint that lazy_scan_heap's "freespace" is used
uninitialized.

Compilers not aware that ereport(ERROR) doesn't return complained
about bbsink_lz4_new().

Assigning "-1" to a uint64 value has unportable results; fortunately,
the value of xlogreadsegno is unimportant when xlogreadfd is -1.
(It looks to me like there is no need for xlogreadsegno to be static
in the first place, but I didn't venture to change that.)
diff --git a/src/backend/access/heap/vacuumlazy.c b/src/backend/access/heap/vacuumlazy.c
@@ -1112,7 +1112,7 @@ lazy_scan_heap(LVRelState *vacrel, int nworkers)
 			if (lazy_scan_noprune(vacrel, buf, blkno, page, &hastup,
 								  &recordfreespace))
 			{
-				Size		freespace;
+				Size		freespace = 0;
 
 				/*
 				 * Processed page successfully (without cleanup lock) -- just
diff --git a/src/backend/replication/basebackup_lz4.c b/src/backend/replication/basebackup_lz4.c
@@ -66,6 +66,7 @@ bbsink_lz4_new(bbsink *next, int compresslevel)
 	ereport(ERROR,
 			(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
 			 errmsg("lz4 compression is not supported by this build")));
+	return NULL;				/* keep compiler quiet */
 #else
 	bbsink_lz4 *sink;
 
diff --git a/src/bin/pg_rewind/parsexlog.c b/src/bin/pg_rewind/parsexlog.c
@@ -38,7 +38,7 @@ static const char *RmgrNames[RM_MAX_ID + 1] = {
 static void extractPageInfo(XLogReaderState *record);
 
 static int	xlogreadfd = -1;
-static XLogSegNo xlogreadsegno = -1;
+static XLogSegNo xlogreadsegno = 0;
 static char xlogfpath[MAXPGPATH];
 
 typedef struct XLogPageReadPrivate

Original file line number	Diff line number	Diff line change
`@@ -1112,7 +1112,7 @@ lazy_scan_heap(LVRelState *vacrel, int nworkers)`
`1112`	`1112`	`if (lazy_scan_noprune(vacrel, buf, blkno, page, &hastup,`
`1113`	`1113`	`&recordfreespace))`
`1114`	`1114`	`{`
`1115`		`- Size freespace;`
	`1115`	`+ Size freespace = 0;`
`1116`	`1116`
`1117`	`1117`	`/*`
`1118`	`1118`	`* Processed page successfully (without cleanup lock) -- just`