Update obsolete index scan TID comments.

petergeoghegan · petergeoghegan · commit 304532421446 · 2024-03-11T18:07:10.000-04:00
Oversight in commit c2fe139.
diff --git a/src/backend/access/hash/hashsearch.c b/src/backend/access/hash/hashsearch.c
@@ -37,8 +37,8 @@ static void _hash_readnext(IndexScanDesc scan, Buffer *bufp,
  *		be pinned but not locked, and so->currPos.itemIndex identifies
  *		which item was previously returned.
  *
- *		On successful exit, scan->xs_ctup.t_self is set to the TID
- *		of the next heap tuple. so->currPos is updated as needed.
+ *		On successful exit, scan->xs_heaptid is set to the TID of the next
+ *		heap tuple.  so->currPos is updated as needed.
  *
  *		On failure exit (no more tuples), we return false with pin
  *		held on bucket page but no pins or locks held on overflow
@@ -279,7 +279,7 @@ _hash_readprev(IndexScanDesc scan,
  *		overflow page, both pin and lock are released whereas if it is a bucket
  *		page then it is pinned but not locked and data about the matching
  *		tuple(s) on the page has been loaded into so->currPos,
- *		scan->xs_ctup.t_self is set to the heap TID of the current tuple.
+ *		scan->xs_heaptid is set to the heap TID of the current tuple.
  *
  *		On failure exit (no more tuples), we return false, with pin held on
  *		bucket page but no pins or locks held on overflow page.
diff --git a/src/backend/access/nbtree/nbtsearch.c b/src/backend/access/nbtree/nbtsearch.c
@@ -861,8 +861,8 @@ _bt_compare(Relation rel,
  *		qualifications in the scan key.  On success exit, the page containing
  *		the current index tuple is pinned but not locked, and data about
  *		the matching tuple(s) on the page has been loaded into so->currPos.
- *		scan->xs_ctup.t_self is set to the heap TID of the current tuple,
- *		and if requested, scan->xs_itup points to a copy of the index tuple.
+ *		scan->xs_heaptid is set to the heap TID of the current tuple, and if
+ *		requested, scan->xs_itup points to a copy of the index tuple.
  *
  * If there are no matching items in the index, we return false, with no
  * pins or locks held.
@@ -1448,9 +1448,9 @@ _bt_first(IndexScanDesc scan, ScanDirection dir)
  *		but is not locked, and so->currPos.itemIndex identifies which item was
  *		previously returned.
  *
- *		On successful exit, scan->xs_ctup.t_self is set to the TID of the
- *		next heap tuple, and if requested, scan->xs_itup points to a copy of
- *		the index tuple.  so->currPos is updated as needed.
+ *		On successful exit, scan->xs_heaptid is set to the TID of the next
+ *		heap tuple, and if requested, scan->xs_itup points to a copy of the
+ *		index tuple.  so->currPos is updated as needed.
  *
  *		On failure exit (no more tuples), we release pin and set
  *		so->currPos.buf to InvalidBuffer.

Original file line number	Diff line number	Diff line change
`@@ -37,8 +37,8 @@ static void _hash_readnext(IndexScanDesc scan, Buffer *bufp,`
`37`	`37`	`* be pinned but not locked, and so->currPos.itemIndex identifies`
`38`	`38`	`* which item was previously returned.`
`39`	`39`	`*`
`40`		`- * On successful exit, scan->xs_ctup.t_self is set to the TID`
`41`		`- * of the next heap tuple. so->currPos is updated as needed.`
	`40`	`+ * On successful exit, scan->xs_heaptid is set to the TID of the next`
	`41`	`+ * heap tuple. so->currPos is updated as needed.`
`42`	`42`	`*`
`43`	`43`	`* On failure exit (no more tuples), we return false with pin`
`44`	`44`	`* held on bucket page but no pins or locks held on overflow`
`@@ -279,7 +279,7 @@ _hash_readprev(IndexScanDesc scan,`
`279`	`279`	`* overflow page, both pin and lock are released whereas if it is a bucket`
`280`	`280`	`* page then it is pinned but not locked and data about the matching`
`281`	`281`	`* tuple(s) on the page has been loaded into so->currPos,`
`282`		`- * scan->xs_ctup.t_self is set to the heap TID of the current tuple.`
	`282`	`+ * scan->xs_heaptid is set to the heap TID of the current tuple.`
`283`	`283`	`*`
`284`	`284`	`* On failure exit (no more tuples), we return false, with pin held on`
`285`	`285`	`* bucket page but no pins or locks held on overflow page.`