pgbench: Remove dead code

alvherre · alvherre · commit 30854d94c627 · 2021-01-28T12:50:40.000-03:00
doConnect() never returns connections in state CONNECTION_BAD, so checking for that is pointless. Remove the code that does. This code has been dead since ba708ea, 20 years ago. Discussion: https://postgr.es/m/20210126195224.GA20361@alvherre.pgsql Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
diff --git a/src/bin/pgbench/pgbench.c b/src/bin/pgbench/pgbench.c
@@ -5676,14 +5676,6 @@ main(int argc, char **argv)
 	if (con == NULL)
 		exit(1);
 
-	if (PQstatus(con) == CONNECTION_BAD)
-	{
-		fprintf(stderr, "connection to database \"%s\" failed\n",
-				PQdb(con) ? PQdb(con) : "");
-		fprintf(stderr, "%s", PQerrorMessage(con));
-		exit(1);
-	}
-
 	if (internal_script_used)
 	{
 		/*
