windows: remove date from version number in win32ver.rc

anarazel · anarazel · commit 31d2c4716e6b · 2022-09-26T11:38:02.000-07:00
This may have served a purpose at some point, but these days it just contributes to a non-reproducible build. Reviewed-by: Peter Eisentraut <peter.eisentraut@enterprisedb.com> Discussion: https://postgr.es/m/c5736f70-bb6d-8d25-e35c-e3d886e4e905@enterprisedb.com Discussion: https://postgr.es/m/1cef5b48-32bd-5cbf-fb62-fb648860f5ef@enterprisedb.com
diff --git a/src/makefiles/Makefile.win32 b/src/makefiles/Makefile.win32
@@ -69,7 +69,6 @@ win32ver.rc: $(top_srcdir)/src/port/win32ver.rc
 	sed -e 's;FILEDESC;$(PGFILEDESC);' \
 	    -e 's;VFT_APP;$(PGFTYPE);' \
 	    -e 's;_ICO_;$(PGICOSTR);' \
-	    -e 's;\(VERSION.*\),0 *$$;\1,'`date '+%y%j' | sed 's/^0*//'`';' \
 	    -e '/_INTERNAL_NAME_/$(if $(shlib),s;_INTERNAL_NAME_;"$(basename $(shlib))";,d)' \
 	    -e '/_ORIGINAL_NAME_/$(if $(shlib),s;_ORIGINAL_NAME_;"$(shlib)";,d)' \
 	  $< >$@
diff --git a/src/tools/msvc/Project.pm b/src/tools/msvc/Project.pm
@@ -367,10 +367,6 @@ sub AddResourceFile
 {
 	my ($self, $dir, $desc, $ico) = @_;
 
-	my ($sec, $min, $hour, $mday, $mon, $year, $wday, $yday, $isdst) =
-	  localtime(time);
-	my $d = sprintf("%02d%03d", ($year - 100), $yday);
-
 	if (Solution::IsNewer("$dir/win32ver.rc", 'src/port/win32ver.rc'))
 	{
 		print "Generating win32ver.rc for $dir\n";
@@ -383,7 +379,6 @@ sub AddResourceFile
 		{
 			s/FILEDESC/"$desc"/gm;
 			s/_ICO_/$icostr/gm;
-			s/(VERSION.*),0/$1,$d/;
 			if ($self->{type} eq "dll")
 			{
 				s/VFT_APP/VFT_DLL/gm;

Original file line number	Diff line number	Diff line change
`@@ -367,10 +367,6 @@ sub AddResourceFile`
`367`	`367`	`{`
`368`	`368`	`my ($self, $dir, $desc, $ico) = @_;`
`369`	`369`
`370`		`- my ($sec, $min, $hour, $mday, $mon, $year, $wday, $yday, $isdst) =`
`371`		`- localtime(time);`
`372`		`- my $d = sprintf("%02d%03d", ($year - 100), $yday);`
`373`		`-`
`374`	`370`	`if (Solution::IsNewer("$dir/win32ver.rc", 'src/port/win32ver.rc'))`
`375`	`371`	`{`
`376`	`372`	`print "Generating win32ver.rc for $dir\n";`
`@@ -383,7 +379,6 @@ sub AddResourceFile`
`383`	`379`	`{`
`384`	`380`	`s/FILEDESC/"$desc"/gm;`
`385`	`381`	`s/_ICO_/$icostr/gm;`
`386`		`- s/(VERSION.*),0/$1,$d/;`
`387`	`382`	`if ($self->{type} eq "dll")`
`388`	`383`	`{`
`389`	`384`	`s/VFT_APP/VFT_DLL/gm;`