Adjust VACUUM hastup LP_REDIRECT comments.

petergeoghegan · petergeoghegan · commit 325bc54eed4e · 2023-01-02T10:18:22.000-08:00
The term "truncation" has been ambiguous since commit 10a8d13 added line pointer array truncation during heap pruning. Clear things up by specifying that we're talking about rel truncation here, to match nearby comments that apply to tuples with storage.
diff --git a/src/backend/access/heap/vacuumlazy.c b/src/backend/access/heap/vacuumlazy.c
@@ -1595,7 +1595,8 @@ lazy_scan_prune(LVRelState *vacrel,
 		/* Redirect items mustn't be touched */
 		if (ItemIdIsRedirected(itemid))
 		{
-			prunestate->hastup = true;	/* page won't be truncatable */
+			/* page makes rel truncation unsafe */
+			prunestate->hastup = true;
 			continue;
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -1595,7 +1595,8 @@ lazy_scan_prune(LVRelState *vacrel,`
`1595`	`1595`	`/* Redirect items mustn't be touched */`
`1596`	`1596`	`if (ItemIdIsRedirected(itemid))`
`1597`	`1597`	`{`
`1598`		`- prunestate->hastup = true; /* page won't be truncatable */`
	`1598`	`+ /* page makes rel truncation unsafe */`
	`1599`	`+ prunestate->hastup = true;`
`1599`	`1600`	`continue;`
`1600`	`1601`	`}`
`1601`	`1602`