Fixed a few memory leaks. One indeed was part of a loop.

Michael Meskes · Michael Meskes · commit 333bc29fcbe3 · 2006-08-21T10:48:21.000Z
diff --git a/src/bin/pg_ctl/pg_ctl.c b/src/bin/pg_ctl/pg_ctl.c
@@ -4,7 +4,7 @@
  *
  * Portions Copyright (c) 1996-2006, PostgreSQL Global Development Group
  *
- * $PostgreSQL: pgsql/src/bin/pg_ctl/pg_ctl.c,v 1.70 2006/06/25 04:37:55 alvherre Exp $
+ * $PostgreSQL: pgsql/src/bin/pg_ctl/pg_ctl.c,v 1.71 2006/08/21 10:48:21 meskes Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -320,6 +320,7 @@ readfile(const char *path)
 		result[nlines++] = xstrdup(buffer);
 
 	fclose(infile);
+	free(buffer);
 	result[nlines] = NULL;
 
 	return result;
@@ -465,6 +466,7 @@ test_postmaster_connection(void)
 		}
 		else
 		{
+			PQfinish(conn);
 			print_msg(".");
 			pg_usleep(1000000); /* 1 sec */
 		}
@@ -854,6 +856,7 @@ do_status(void)
 				if (optlines != NULL)
 					for (; *optlines != NULL; optlines++)
 						fputs(*optlines, stdout);
+				free(optlines);
 				return;
 			}
 		}

Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,7 @@`
`4`	`4`	`*`
`5`	`5`	`* Portions Copyright (c) 1996-2006, PostgreSQL Global Development Group`
`6`	`6`	`*`
`7`		`- * $PostgreSQL: pgsql/src/bin/pg_ctl/pg_ctl.c,v 1.70 2006/06/25 04:37:55 alvherre Exp $`
	`7`	`+ * $PostgreSQL: pgsql/src/bin/pg_ctl/pg_ctl.c,v 1.71 2006/08/21 10:48:21 meskes Exp $`
`8`	`8`	`*`
`9`	`9`	`*-------------------------------------------------------------------------`
`10`	`10`	`*/`
`@@ -320,6 +320,7 @@ readfile(const char *path)`
`320`	`320`	`result[nlines++] = xstrdup(buffer);`
`321`	`321`
`322`	`322`	`fclose(infile);`
	`323`	`+ free(buffer);`
`323`	`324`	`result[nlines] = NULL;`
`324`	`325`
`325`	`326`	`return result;`
`@@ -465,6 +466,7 @@ test_postmaster_connection(void)`
`465`	`466`	`}`
`466`	`467`	`else`
`467`	`468`	`{`
	`469`	`+ PQfinish(conn);`
`468`	`470`	`print_msg(".");`
`469`	`471`	`pg_usleep(1000000); /* 1 sec */`
`470`	`472`	`}`
`@@ -854,6 +856,7 @@ do_status(void)`
`854`	`856`	`if (optlines != NULL)`
`855`	`857`	`for (; *optlines != NULL; optlines++)`
`856`	`858`	`fputs(*optlines, stdout);`
	`859`	`+ free(optlines);`
`857`	`860`	`return;`
`858`	`861`	`}`
`859`	`862`	`}`