Clear some style deviations.

nmisch · nmisch · commit 3350fb5d1f9d · 2020-05-21T08:31:16.000-07:00
diff --git a/contrib/pgcrypto/pgp-mpi-internal.c b/contrib/pgcrypto/pgp-mpi-internal.c
@@ -35,7 +35,7 @@
 #include "px.h"
 
 static mpz_t *
-mp_new()
+mp_new(void)
 {
 	mpz_t	   *mp = mp_int_alloc();
 
diff --git a/src/backend/postmaster/autovacuum.c b/src/backend/postmaster/autovacuum.c
@@ -834,7 +834,7 @@ HandleAutoVacLauncherInterrupts(void)
  * Perform a normal exit from the autovac launcher.
  */
 static void
-AutoVacLauncherShutdown()
+AutoVacLauncherShutdown(void)
 {
 	ereport(DEBUG1,
 			(errmsg("autovacuum launcher shutting down")));
diff --git a/src/backend/storage/buffer/freelist.c b/src/backend/storage/buffer/freelist.c
@@ -177,7 +177,7 @@ ClockSweepTick(void)
  * should not call this.
  */
 bool
-have_free_buffer()
+have_free_buffer(void)
 {
 	if (StrategyControl->firstFreeBuffer >= 0)
 		return true;
diff --git a/src/backend/storage/smgr/md.c b/src/backend/storage/smgr/md.c
@@ -1114,7 +1114,7 @@ _mdfd_openseg(SMgrRelation reln, ForkNumber forknum, BlockNumber segno,
 			  int oflags)
 {
 	MdfdVec    *v;
-	int			fd;
+	File		fd;
 	char	   *fullpath;
 
 	fullpath = _mdfd_segpath(reln, forknum, segno);
diff --git a/src/backend/utils/misc/queryenvironment.c b/src/backend/utils/misc/queryenvironment.c
@@ -36,7 +36,7 @@ struct QueryEnvironment
 
 
 QueryEnvironment *
-create_queryEnv()
+create_queryEnv(void)
 {
 	return (QueryEnvironment *) palloc0(sizeof(QueryEnvironment));
 }
diff --git a/src/interfaces/libpq/fe-misc.c b/src/interfaces/libpq/fe-misc.c
@@ -1250,7 +1250,7 @@ PQenv2encoding(void)
 #ifdef ENABLE_NLS
 
 static void
-libpq_binddomain()
+libpq_binddomain(void)
 {
 	static bool already_bound = false;
 
diff --git a/src/pl/plpython/plpy_cursorobject.c b/src/pl/plpython/plpy_cursorobject.c
@@ -27,9 +27,7 @@ static PyObject *PLy_cursor_iternext(PyObject *self);
 static PyObject *PLy_cursor_fetch(PyObject *self, PyObject *args);
 static PyObject *PLy_cursor_close(PyObject *self, PyObject *unused);
 
-static char PLy_cursor_doc[] = {
-	"Wrapper around a PostgreSQL cursor"
-};
+static char PLy_cursor_doc[] = "Wrapper around a PostgreSQL cursor";
 
 static PyMethodDef PLy_cursor_methods[] = {
 	{"fetch", PLy_cursor_fetch, METH_VARARGS, NULL},
diff --git a/src/pl/plpython/plpy_planobject.c b/src/pl/plpython/plpy_planobject.c
@@ -18,9 +18,7 @@ static PyObject *PLy_plan_cursor(PyObject *self, PyObject *args);
 static PyObject *PLy_plan_execute(PyObject *self, PyObject *args);
 static PyObject *PLy_plan_status(PyObject *self, PyObject *args);
 
-static char PLy_plan_doc[] = {
-	"Store a PostgreSQL plan"
-};
+static char PLy_plan_doc[] = "Store a PostgreSQL plan";
 
 static PyMethodDef PLy_plan_methods[] = {
 	{"cursor", PLy_plan_cursor, METH_VARARGS, NULL},
diff --git a/src/pl/plpython/plpy_resultobject.c b/src/pl/plpython/plpy_resultobject.c
@@ -22,9 +22,7 @@ static PyObject *PLy_result_str(PyObject *arg);
 static PyObject *PLy_result_subscript(PyObject *arg, PyObject *item);
 static int	PLy_result_ass_subscript(PyObject *self, PyObject *item, PyObject *value);
 
-static char PLy_result_doc[] = {
-	"Results of a PostgreSQL query"
-};
+static char PLy_result_doc[] = "Results of a PostgreSQL query";
 
 static PySequenceMethods PLy_result_as_sequence = {
 	.sq_length = PLy_result_length,
diff --git a/src/pl/plpython/plpy_subxactobject.c b/src/pl/plpython/plpy_subxactobject.c
@@ -19,9 +19,8 @@ static void PLy_subtransaction_dealloc(PyObject *subxact);
 static PyObject *PLy_subtransaction_enter(PyObject *self, PyObject *unused);
 static PyObject *PLy_subtransaction_exit(PyObject *self, PyObject *args);
 
-static char PLy_subtransaction_doc[] = {
-	"PostgreSQL subtransaction context manager"
-};
+static char PLy_subtransaction_doc[] =
+"PostgreSQL subtransaction context manager";
 
 static PyMethodDef PLy_subtransaction_methods[] = {
 	{"__enter__", PLy_subtransaction_enter, METH_VARARGS, NULL},
diff --git a/src/port/random.c b/src/port/random.c
@@ -19,7 +19,7 @@
 
 
 long
-random()
+random(void)
 {
 	return pg_lrand48();
 }

Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,7 @@`
`35`	`35`	`#include "px.h"`
`36`	`36`
`37`	`37`	`static mpz_t *`
`38`		`-mp_new()`
	`38`	`+mp_new(void)`
`39`	`39`	`{`
`40`	`40`	`mpz_t *mp = mp_int_alloc();`
`41`	`41`
Original file line number	Diff line number	Diff line change
`@@ -834,7 +834,7 @@ HandleAutoVacLauncherInterrupts(void)`
`834`	`834`	`* Perform a normal exit from the autovac launcher.`
`835`	`835`	`*/`
`836`	`836`	`static void`
`837`		`-AutoVacLauncherShutdown()`
	`837`	`+AutoVacLauncherShutdown(void)`
`838`	`838`	`{`
`839`	`839`	`ereport(DEBUG1,`
`840`	`840`	`(errmsg("autovacuum launcher shutting down")));`
Original file line number	Diff line number	Diff line change
`@@ -177,7 +177,7 @@ ClockSweepTick(void)`
`177`	`177`	`* should not call this.`
`178`	`178`	`*/`
`179`	`179`	`bool`
`180`		`-have_free_buffer()`
	`180`	`+have_free_buffer(void)`
`181`	`181`	`{`
`182`	`182`	`if (StrategyControl->firstFreeBuffer >= 0)`
`183`	`183`	`return true;`
Original file line number	Diff line number	Diff line change
`@@ -1114,7 +1114,7 @@ _mdfd_openseg(SMgrRelation reln, ForkNumber forknum, BlockNumber segno,`
`1114`	`1114`	`int oflags)`
`1115`	`1115`	`{`
`1116`	`1116`	`MdfdVec *v;`
`1117`		`- int fd;`
	`1117`	`+ File fd;`
`1118`	`1118`	`char *fullpath;`
`1119`	`1119`
`1120`	`1120`	`fullpath = _mdfd_segpath(reln, forknum, segno);`
Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,7 @@ struct QueryEnvironment`
`36`	`36`
`37`	`37`
`38`	`38`	`QueryEnvironment *`
`39`		`-create_queryEnv()`
	`39`	`+create_queryEnv(void)`
`40`	`40`	`{`
`41`	`41`	`return (QueryEnvironment *) palloc0(sizeof(QueryEnvironment));`
`42`	`42`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1250,7 +1250,7 @@ PQenv2encoding(void)`
`1250`	`1250`	`#ifdef ENABLE_NLS`
`1251`	`1251`
`1252`	`1252`	`static void`
`1253`		`-libpq_binddomain()`
	`1253`	`+libpq_binddomain(void)`
`1254`	`1254`	`{`
`1255`	`1255`	`static bool already_bound = false;`
`1256`	`1256`