Fix code comments still referring to pg_start/stop_backup()

michaelpq · michaelpq · commit 33bd4698c117 · 2022-07-01T09:37:17.000+09:00
pg_start_backup() and pg_stop_backup() have been respectively renamed to pg_backup_start() and pg_backup_stop() as of 39969e2, but a few comments did not get the call. Reviewed-by: Kyotaro Horiguchi, David Steele Discussion: https://postgr.es/m/YrqGlj1+4DF3dbZ/@paquier.xyz
diff --git a/src/backend/access/transam/xlogrecovery.c b/src/backend/access/transam/xlogrecovery.c
@@ -716,7 +716,7 @@ InitWalRecovery(ControlFileData *ControlFile, bool *wasShutdown_ptr,
 		 * know how far we need to replay the WAL before we reach consistency.
 		 * This can happen for example if a base backup is taken from a
 		 * running server using an atomic filesystem snapshot, without calling
-		 * pg_start/stop_backup. Or if you just kill a running primary server
+		 * pg_backup_start/stop. Or if you just kill a running primary server
 		 * and put it into archive recovery by creating a recovery signal
 		 * file.
 		 *
diff --git a/src/backend/replication/basebackup.c b/src/backend/replication/basebackup.c
@@ -16,7 +16,7 @@
 #include <unistd.h>
 #include <time.h>
 
-#include "access/xlog_internal.h"	/* for pg_start/stop_backup */
+#include "access/xlog_internal.h"	/* for pg_backup_start/stop */
 #include "common/compression.h"
 #include "common/file_perm.h"
 #include "commands/defrem.h"

Original file line number	Diff line number	Diff line change
`@@ -716,7 +716,7 @@ InitWalRecovery(ControlFileData ControlFile, bool wasShutdown_ptr,`
`716`	`716`	`* know how far we need to replay the WAL before we reach consistency.`
`717`	`717`	`* This can happen for example if a base backup is taken from a`
`718`	`718`	`* running server using an atomic filesystem snapshot, without calling`
`719`		`- * pg_start/stop_backup. Or if you just kill a running primary server`
	`719`	`+ * pg_backup_start/stop. Or if you just kill a running primary server`
`720`	`720`	`* and put it into archive recovery by creating a recovery signal`
`721`	`721`	`* file.`
`722`	`722`	`*`