Skip to content

Commit 390e59c

Browse files
committed
Fix obsolete comment. It's no longer the case that Param nodes don't
carry typmod.
1 parent 0ba9b56 commit 390e59c

File tree

1 file changed

+4
-9
lines changed

1 file changed

+4
-9
lines changed

src/backend/optimizer/plan/subselect.c

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* Portions Copyright (c) 1994, Regents of the University of California
88
*
99
* IDENTIFICATION
10-
* $PostgreSQL: pgsql/src/backend/optimizer/plan/subselect.c,v 1.135 2008/08/17 02:19:19 tgl Exp $
10+
* $PostgreSQL: pgsql/src/backend/optimizer/plan/subselect.c,v 1.136 2008/08/20 15:49:30 tgl Exp $
1111
*
1212
*-------------------------------------------------------------------------
1313
*/
@@ -94,14 +94,9 @@ replace_outer_var(PlannerInfo *root, Var *var)
9494
* NOTE: in sufficiently complex querytrees, it is possible for the same
9595
* varno/abslevel to refer to different RTEs in different parts of the
9696
* parsetree, so that different fields might end up sharing the same Param
97-
* number. As long as we check the vartype as well, I believe that this
98-
* sort of aliasing will cause no trouble. The correct field should get
99-
* stored into the Param slot at execution in each part of the tree.
100-
*
101-
* We also need to demand a match on vartypmod. This does not matter for
102-
* the Param itself, since those are not typmod-dependent, but it does
103-
* matter when make_subplan() instantiates a modified copy of the Var for
104-
* a subplan's args list.
97+
* number. As long as we check the vartype/typmod as well, I believe that
98+
* this sort of aliasing will cause no trouble. The correct field should
99+
* get stored into the Param slot at execution in each part of the tree.
105100
*/
106101
i = 0;
107102
foreach(ppl, root->glob->paramlist)

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy