postgres_fdw: Remove useless if-test in GetConnection().

Etsuro Fujita · Etsuro Fujita · commit 39a3bdc9eba5 · 2023-03-17T18:15:00.000+09:00
Checking whether entry->conn is NULL after doing disconnect_pg_server() for that entry is pointless, as that function ensures that it is NULL. Thinko in commit 7fc1a81; this would be harmless, so patch HEAD only. Reviewed-by: Richard Guo and Daniel Gustafsson Discussion: https://postgr.es/m/CAPmGK169vQ83PQwQkoxO-AK2EeK1EsgsxixedM%2BBLWEAhZ_AqQ%40mail.gmail.com
diff --git a/contrib/postgres_fdw/connection.c b/contrib/postgres_fdw/connection.c
@@ -271,8 +271,7 @@ GetConnection(UserMapping *user, bool will_prep_stmt, PgFdwConnState **state)
 			 entry->conn);
 		disconnect_pg_server(entry);
 
-		if (entry->conn == NULL)
-			make_new_connection(entry, user);
+		make_new_connection(entry, user);
 
 		begin_remote_xact(entry);
 	}

Original file line number	Diff line number	Diff line change
`@@ -271,8 +271,7 @@ GetConnection(UserMapping user, bool will_prep_stmt, PgFdwConnState *state)`
`271`	`271`	`entry->conn);`
`272`	`272`	`disconnect_pg_server(entry);`
`273`	`273`
`274`		`- if (entry->conn == NULL)`
`275`		`- make_new_connection(entry, user);`
	`274`	`+ make_new_connection(entry, user);`
`276`	`275`
`277`	`276`	`begin_remote_xact(entry);`
`278`	`277`	`}`