Remove ill-conceived Assertion in ProcessClientWriteInterrupt().

anarazel · anarazel · commit 3a54f4a4944b · 2015-02-03T23:52:15.000+01:00
It's perfectly fine to have blocked interrupts when
ProcessClientWriteInterrupt() is called. In fact it's commonly the
case when emitting error reports. And we deal with that correctly.

Even if that'd not be the case, it'd be a bad location for such a
assertion. Because ProcessClientWriteInterrupt() is only called when
the socket is blocked it's hard to hit.

Per Heikki and buildfarm animals nightjar and dunlin.
diff --git a/src/backend/tcop/postgres.c b/src/backend/tcop/postgres.c
@@ -571,8 +571,6 @@ ProcessClientWriteInterrupt(bool blocked)
 {
 	int			save_errno = errno;
 
-	Assert(InterruptHoldoffCount == 0 && CritSectionCount == 0);
-
 	/*
 	 * We only want to process the interrupt here if socket writes are
 	 * blocking to increase the chance to get an error message to the

Original file line number	Diff line number	Diff line change
`@@ -571,8 +571,6 @@ ProcessClientWriteInterrupt(bool blocked)`
`571`	`571`	`{`
`572`	`572`	`int save_errno = errno;`
`573`	`573`
`574`		`- Assert(InterruptHoldoffCount == 0 && CritSectionCount == 0);`
`575`		`-`
`576`	`574`	`/*`
`577`	`575`	`* We only want to process the interrupt here if socket writes are`
`578`	`576`	`* blocking to increase the chance to get an error message to the`