Remove redundant nbtree preprocessing assertions.

petergeoghegan · petergeoghegan · commit 3b08133cd13c · 2024-04-07T22:13:28.000-04:00
One of the assertions was the subject of a false positive complaint from Coverity, but none of the assertions added much, so get rid of them. Reported-By: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/3000247.1712537309@sss.pgh.pa.us
diff --git a/src/backend/access/nbtree/nbtutils.c b/src/backend/access/nbtree/nbtutils.c
@@ -2937,7 +2937,6 @@ _bt_preprocess_keys(IndexScanDesc scan)
 					if (j != (BTEqualStrategyNumber - 1) ||
 						!(xform[j].skey->sk_flags & SK_SEARCHARRAY))
 					{
-						Assert(!array || array->scan_key == i);
 						xform[j].skey = cur;
 						xform[j].ikey = i;
 						xform[j].arrayidx = arrayidx;
@@ -2951,9 +2950,6 @@ _bt_preprocess_keys(IndexScanDesc scan)
 						 * scan key.  _bt_compare_scankey_args expects us to
 						 * always keep arrays (and discard non-arrays).
 						 */
-						Assert(j == (BTEqualStrategyNumber - 1));
-						Assert(xform[j].skey->sk_flags & SK_SEARCHARRAY);
-						Assert(xform[j].ikey == array->scan_key);
 						Assert(!(cur->sk_flags & SK_SEARCHARRAY));
 					}
 				}

Original file line number	Diff line number	Diff line change
`@@ -2937,7 +2937,6 @@ _bt_preprocess_keys(IndexScanDesc scan)`
`2937`	`2937`	`if (j != (BTEqualStrategyNumber - 1) \|\|`
`2938`	`2938`	`!(xform[j].skey->sk_flags & SK_SEARCHARRAY))`
`2939`	`2939`	`{`
`2940`		`- Assert(!array \|\| array->scan_key == i);`
`2941`	`2940`	`xform[j].skey = cur;`
`2942`	`2941`	`xform[j].ikey = i;`
`2943`	`2942`	`xform[j].arrayidx = arrayidx;`
`@@ -2951,9 +2950,6 @@ _bt_preprocess_keys(IndexScanDesc scan)`
`2951`	`2950`	`* scan key. _bt_compare_scankey_args expects us to`
`2952`	`2951`	`* always keep arrays (and discard non-arrays).`
`2953`	`2952`	`*/`
`2954`		`- Assert(j == (BTEqualStrategyNumber - 1));`
`2955`		`- Assert(xform[j].skey->sk_flags & SK_SEARCHARRAY);`
`2956`		`- Assert(xform[j].ikey == array->scan_key);`
`2957`	`2953`	`Assert(!(cur->sk_flags & SK_SEARCHARRAY));`
`2958`	`2954`	`}`
`2959`	`2955`	`}`