Fix resource leak pointed out by Coverity.

tatsuo-ishii · tatsuo-ishii · commit 3b5a89c4820f · 2014-12-30T20:33:01.000+09:00
diff --git a/contrib/pgbench/pgbench.c b/contrib/pgbench/pgbench.c
@@ -2134,6 +2134,7 @@ parseQuery(Command *cmd, const char *raw_sql)
 		if (cmd->argc >= MAX_ARGS)
 		{
 			fprintf(stderr, "statement has too many arguments (maximum is %d): %s\n", MAX_ARGS - 1, raw_sql);
+			pg_free(name);
 			return false;
 		}
 
@@ -2410,6 +2411,7 @@ process_file(char *filename)
 	else if ((fd = fopen(filename, "r")) == NULL)
 	{
 		fprintf(stderr, "%s: %s\n", filename, strerror(errno));
+		pg_free(my_commands);
 		return false;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -2134,6 +2134,7 @@ parseQuery(Command cmd, const char raw_sql)`
`2134`	`2134`	`if (cmd->argc >= MAX_ARGS)`
`2135`	`2135`	`{`
`2136`	`2136`	`fprintf(stderr, "statement has too many arguments (maximum is %d): %s\n", MAX_ARGS - 1, raw_sql);`
	`2137`	`+ pg_free(name);`
`2137`	`2138`	`return false;`
`2138`	`2139`	`}`
`2139`	`2140`
`@@ -2410,6 +2411,7 @@ process_file(char *filename)`
`2410`	`2411`	`else if ((fd = fopen(filename, "r")) == NULL)`
`2411`	`2412`	`{`
`2412`	`2413`	`fprintf(stderr, "%s: %s\n", filename, strerror(errno));`
	`2414`	`+ pg_free(my_commands);`
`2413`	`2415`	`return false;`
`2414`	`2416`	`}`
`2415`	`2417`