Fix TAP tests for older Perls.

tglsfdc · tglsfdc · commit 3b8d7215533e · 2016-03-02T01:06:31.000-05:00
Commit 7132810 (Retain tempdirs for failed tests) used Test::More's is_passing method, but that was added in Test::More 0.89_01 which is sometime later than Perl 5.10.1. Popular platforms such as RHEL6 don't have that, nevermind some of our older dinosaurs. Do it the hard way. Michael Paquier, based on research by Craig Ringer
diff --git a/src/test/perl/TestLib.pm b/src/test/perl/TestLib.pm
@@ -110,7 +110,17 @@ INIT
 END
 {
 	# Preserve temporary directory for this test on failure
-	$File::Temp::KEEP_ALL = 1 unless Test::More->builder->is_passing;
+	$File::Temp::KEEP_ALL = 1 unless all_tests_passing();
+}
+
+sub all_tests_passing
+{
+	my $fail_count = 0;
+	foreach my $status (Test::More->builder->summary)
+	{
+		return 0 unless $status;
+	}
+	return 1;
 }
 
 #

Original file line number	Diff line number	Diff line change
`@@ -110,7 +110,17 @@ INIT`
`110`	`110`	`END`
`111`	`111`	`{`
`112`	`112`	`# Preserve temporary directory for this test on failure`
`113`		`- $File::Temp::KEEP_ALL = 1 unless Test::More->builder->is_passing;`
	`113`	`+ $File::Temp::KEEP_ALL = 1 unless all_tests_passing();`
	`114`	`+}`
	`115`	`+`
	`116`	`+sub all_tests_passing`
	`117`	`+{`
	`118`	`+ my $fail_count = 0;`
	`119`	`+ foreach my $status (Test::More->builder->summary)`
	`120`	`+ {`
	`121`	`+ return 0 unless $status;`
	`122`	`+ }`
	`123`	`+ return 1;`
`114`	`124`	`}`
`115`	`125`
`116`	`126`	`#`