Suppress "variable may be used uninitialized" warning.

tglsfdc · tglsfdc · commit 3c5ff36aba8a · 2024-04-05T10:58:30.000-04:00
Buildfarm member caiman is showing this, which surprises me because
it's very late-model gcc (14.0.1) and ought to be smart enough to
know that elog(ERROR) doesn't return.  But we're likely to see the
same from stupider compilers too, so add a dummy initialization in
our usual style.
diff --git a/src/backend/parser/parse_expr.c b/src/backend/parser/parse_expr.c
@@ -4276,6 +4276,7 @@ transformJsonFuncExpr(ParseState *pstate, JsonFuncExpr *func)
 			break;
 		default:
 			elog(ERROR, "invalid JsonFuncExpr op %d", (int) func->op);
+			default_format = JS_FORMAT_DEFAULT; /* keep compiler quiet */
 			break;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -4276,6 +4276,7 @@ transformJsonFuncExpr(ParseState pstate, JsonFuncExpr func)`
`4276`	`4276`	`break;`
`4277`	`4277`	`default:`
`4278`	`4278`	`elog(ERROR, "invalid JsonFuncExpr op %d", (int) func->op);`
	`4279`	`+ default_format = JS_FORMAT_DEFAULT; /* keep compiler quiet */`
`4279`	`4280`	`break;`
`4280`	`4281`	`}`
`4281`	`4282`