Explicitly ignore guaranteed-true result from pgstat_lock_entry().

tglsfdc · tglsfdc · commit 3c702b3ed151 · 2022-04-11T13:22:37.000-04:00
With nowait passed as false, pgstat_lock_entry() must return true
so there's no need to check its result.  Coverity seems unconvinced
of this, so whack it upside the head with a (void) cast.
diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
@@ -920,7 +920,7 @@ pgstat_reset_entry(PgStat_Kind kind, Oid dboid, Oid objoid, TimestampTz ts)
 	if (!entry_ref || entry_ref->shared_entry->dropped)
 		return;
 
-	pgstat_lock_entry(entry_ref, false);
+	(void) pgstat_lock_entry(entry_ref, false);
 	shared_stat_reset_contents(kind, entry_ref->shared_stats, ts);
 	pgstat_unlock_entry(entry_ref);
 }

Original file line number	Diff line number	Diff line change
`@@ -920,7 +920,7 @@ pgstat_reset_entry(PgStat_Kind kind, Oid dboid, Oid objoid, TimestampTz ts)`
`920`	`920`	`if (!entry_ref \|\| entry_ref->shared_entry->dropped)`
`921`	`921`	`return;`
`922`	`922`
`923`		`- pgstat_lock_entry(entry_ref, false);`
	`923`	`+ (void) pgstat_lock_entry(entry_ref, false);`
`924`	`924`	`shared_stat_reset_contents(kind, entry_ref->shared_stats, ts);`
`925`	`925`	`pgstat_unlock_entry(entry_ref);`
`926`	`926`	`}`