Fix oversight in recent pg_basebackup fix causing pg_receivexlog failures.

anarazel · anarazel · commit 3c9e4cdbf2ec · 2015-01-05T12:31:05.000+01:00
A oversight in 2c0a485 causes 'could not create archive status file "...": No such file or directory' errors in pg_receivexlog if the target directory doesn't happen to contain a archive_status directory. That's due to a stupidly left over 'true' constant instead of mark_done being passed down to ProcessXLogDataMsg(). The bug is only present in the master branch, and luckily wasn't released. Spotted by Fujii Masao.
diff --git a/src/bin/pg_basebackup/receivelog.c b/src/bin/pg_basebackup/receivelog.c
@@ -906,7 +906,7 @@ HandleCopyStream(PGconn *conn, XLogRecPtr startpos, uint32 timeline,
 			{
 				if (!ProcessXLogDataMsg(conn, copybuf, r, &blockpos,
 										timeline, basedir, stream_stop,
-										partial_suffix, true))
+										partial_suffix, mark_done))
 					goto error;
 
 				/*

Original file line number	Diff line number	Diff line change
`@@ -906,7 +906,7 @@ HandleCopyStream(PGconn *conn, XLogRecPtr startpos, uint32 timeline,`
`906`	`906`	`{`
`907`	`907`	`if (!ProcessXLogDataMsg(conn, copybuf, r, &blockpos,`
`908`	`908`	`timeline, basedir, stream_stop,`
`909`		`- partial_suffix, true))`
	`909`	`+ partial_suffix, mark_done))`
`910`	`910`	`goto error;`
`911`	`911`
`912`	`912`	`/*`