Fix pg_restore -n option to do what the man page says it does. The

tglsfdc · tglsfdc · commit 3ef151e0b779 · 2006-04-12T22:18:48.000Z
original coding only worked if one of the selTypes restriction options
was also given.  Per report from Nick Johnson.
diff --git a/src/bin/pg_dump/pg_backup_archiver.c b/src/bin/pg_dump/pg_backup_archiver.c
@@ -15,7 +15,7 @@
  *
  *
  * IDENTIFICATION
- *		$PostgreSQL: pgsql/src/bin/pg_dump/pg_backup_archiver.c,v 1.125 2006/02/14 23:30:43 tgl Exp $
+ *		$PostgreSQL: pgsql/src/bin/pg_dump/pg_backup_archiver.c,v 1.126 2006/04/12 22:18:48 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -1908,17 +1908,18 @@ _tocEntryRequired(TocEntry *te, RestoreOptions *ropt, bool include_acls)
 	if (!ropt->create && strcmp(te->desc, "DATABASE") == 0)
 		return 0;
 
-	/* Check if tablename only is wanted */
+	/* Check options for selective dump/restore */
+	if (ropt->schemaNames)
+	{
+		/* If no namespace is specified, it means all. */
+		if (!te->namespace)
+			return 0;
+		if (strcmp(ropt->schemaNames, te->namespace) != 0)
+			return 0;
+	}
+
 	if (ropt->selTypes)
 	{
-		if (ropt->schemaNames)
-		{
-			/* If no namespace is specified, it means all. */
-			if (!te->namespace)
-				return 0;
-			if (strcmp(ropt->schemaNames, te->namespace) != 0)
-				return 0;
-		}
 		if (strcmp(te->desc, "TABLE") == 0 ||
 			strcmp(te->desc, "TABLE DATA") == 0)
 		{
diff --git a/src/bin/pg_dump/pg_restore.c b/src/bin/pg_dump/pg_restore.c
@@ -34,7 +34,7 @@
  *
  *
  * IDENTIFICATION
- *		$PostgreSQL: pgsql/src/bin/pg_dump/pg_restore.c,v 1.76 2006/02/12 06:11:51 momjian Exp $
+ *		$PostgreSQL: pgsql/src/bin/pg_dump/pg_restore.c,v 1.77 2006/04/12 22:18:48 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -188,7 +188,6 @@ main(int argc, char **argv)
 				break;
 
 			case 'n':			/* Dump data for this schema only */
-				opts->selTypes = 1;
 				opts->schemaNames = strdup(optarg);
 				break;
 

Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,7 @@`
`34`	`34`	`*`
`35`	`35`	`*`
`36`	`36`	`* IDENTIFICATION`
`37`		`- * $PostgreSQL: pgsql/src/bin/pg_dump/pg_restore.c,v 1.76 2006/02/12 06:11:51 momjian Exp $`
	`37`	`+ * $PostgreSQL: pgsql/src/bin/pg_dump/pg_restore.c,v 1.77 2006/04/12 22:18:48 tgl Exp $`
`38`	`38`	`*`
`39`	`39`	`*-------------------------------------------------------------------------`
`40`	`40`	`*/`
`@@ -188,7 +188,6 @@ main(int argc, char **argv)`
`188`	`188`	`break;`
`189`	`189`
`190`	`190`	`case 'n': /* Dump data for this schema only */`
`191`		`- opts->selTypes = 1;`
`192`	`191`	`opts->schemaNames = strdup(optarg);`
`193`	`192`	`break;`
`194`	`193`