Add comments that Solaris Sun compiler only supports sparc9 ASM,

bmomjian · bmomjian · commit 407885ea3b70 · 2006-05-17T23:57:03.000Z
diff --git a/src/backend/port/tas/solaris_sparc.s b/src/backend/port/tas/solaris_sparc.s
@@ -16,6 +16,23 @@
 	.global pg_atomic_cas
 pg_atomic_cas:
 	
+	! "cas" only works on sparcv9 chips, and requies a compiler
+	! that is targeting sparcv9.  It will fail on a compiler
+	! targeting sparcv8, and of course will not be understood
+	! by a sparcv8 CPU.  If this fails on existing Solaris
+	! systems, we need to use a !defined(__sparcv9) test
+	! to fall back to the old "ldstub" call for sparcv8 compiles.
+	! gcc continues to use "ldstub" because there is no indication
+	! which sparc version it is targeting.
+	!
+	! There actually is a trick for embedding "cas" for a compiler
+	! that is targeting sparcv8:
+	!
+	!   http://cvs.opensolaris.org/source/xref/on/usr/src/lib/libc/sparc/threads/sparc.il
+	!
+	! This might work for sparc8:
+	! ldstub [%o0],%o1	! moves only a byte
+
 	cas     [%o0],%o2,%o1
 	mov     %o1,%o0
 	retl
diff --git a/src/include/storage/s_lock.h b/src/include/storage/s_lock.h
@@ -66,7 +66,7 @@
  * Portions Copyright (c) 1996-2006, PostgreSQL Global Development Group
  * Portions Copyright (c) 1994, Regents of the University of California
  *
- *	  $PostgreSQL: pgsql/src/include/storage/s_lock.h,v 1.152 2006/04/29 11:55:19 momjian Exp $
+ *	  $PostgreSQL: pgsql/src/include/storage/s_lock.h,v 1.153 2006/05/17 23:57:03 momjian Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -311,6 +311,10 @@ tas(volatile slock_t *lock)
 {
 	register slock_t _res;
 
+	/*
+	 *	See comment in /pg/backend/port/tas/solaris_sparc.s for why this
+	 *	uses "ldstub", and that file uses "cas".
+	 */
 	__asm__ __volatile__(
 		"	ldstub	[%2], %0	\n"
 :		"=r"(_res), "+m"(*lock)

Original file line number	Diff line number	Diff line change
`@@ -66,7 +66,7 @@`
`66`	`66`	`* Portions Copyright (c) 1996-2006, PostgreSQL Global Development Group`
`67`	`67`	`* Portions Copyright (c) 1994, Regents of the University of California`
`68`	`68`	`*`
`69`		`- * $PostgreSQL: pgsql/src/include/storage/s_lock.h,v 1.152 2006/04/29 11:55:19 momjian Exp $`
	`69`	`+ * $PostgreSQL: pgsql/src/include/storage/s_lock.h,v 1.153 2006/05/17 23:57:03 momjian Exp $`
`70`	`70`	`*`
`71`	`71`	`*-------------------------------------------------------------------------`
`72`	`72`	`*/`
`@@ -311,6 +311,10 @@ tas(volatile slock_t *lock)`
`311`	`311`	`{`
`312`	`312`	`register slock_t _res;`
`313`	`313`
	`314`	`+ /*`
	`315`	`+ * See comment in /pg/backend/port/tas/solaris_sparc.s for why this`
	`316`	`+ * uses "ldstub", and that file uses "cas".`
	`317`	`+ */`
`314`	`318`	`__asm__ __volatile__(`
`315`	`319`	`" ldstub [%2], %0 \n"`
`316`	`320`	`: "=r"(_res), "+m"(*lock)`