Adjust pg_dump tag for relation stats.

jeff-davis · jeff-davis · commit 424ededc580b · 2025-02-27T20:42:12.000-08:00
Do not use fmtId(), just use dobj-&gt;name directly, like for table data.
diff --git a/src/bin/pg_dump/pg_dump.c b/src/bin/pg_dump/pg_dump.c
@@ -10490,7 +10490,6 @@ dumpRelationStats(Archive *fout, const RelStatsInfo *rsinfo)
 	PGresult   *res;
 	PQExpBuffer query;
 	PQExpBuffer out;
-	PQExpBuffer tag;
 	DumpId	   *deps = NULL;
 	int			ndeps = 0;
 	char	   *qualified_name;
@@ -10522,9 +10521,6 @@ dumpRelationStats(Archive *fout, const RelStatsInfo *rsinfo)
 		ndeps = dobj->nDeps;
 	}
 
-	tag = createPQExpBuffer();
-	appendPQExpBufferStr(tag, fmtId(dobj->name));
-
 	query = createPQExpBuffer();
 	if (!fout->is_prepared[PREPQUERY_GETATTRIBUTESTATS])
 	{
@@ -10695,7 +10691,7 @@ dumpRelationStats(Archive *fout, const RelStatsInfo *rsinfo)
 	PQclear(res);
 
 	ArchiveEntry(fout, nilCatalogId, createDumpId(),
-				 ARCHIVE_OPTS(.tag = tag->data,
+				 ARCHIVE_OPTS(.tag = dobj->name,
 							  .namespace = dobj->namespace->dobj.name,
 							  .description = "STATISTICS DATA",
 							  .section = rsinfo->postponed_def ?
@@ -10707,7 +10703,6 @@ dumpRelationStats(Archive *fout, const RelStatsInfo *rsinfo)
 	free(qualified_name);
 	destroyPQExpBuffer(out);
 	destroyPQExpBuffer(query);
-	destroyPQExpBuffer(tag);
 }
 
 /*
