Fix bug in WAL replay of COMMIT_TS_SETTS record.

MasaoFujii · MasaoFujii · commit 438fc4a39c39 · 2021-03-25T11:23:30.000+09:00
Previously the WAL replay of COMMIT_TS_SETTS record called TransactionTreeSetCommitTsData() with the argument write_xlog=true, which generated and wrote new COMMIT_TS_SETTS record. This should not be acceptable because it's during recovery. This commit fixes the WAL replay of COMMIT_TS_SETTS record so that it calls TransactionTreeSetCommitTsData() with write_xlog=false and doesn't generate new WAL during recovery. Back-patch to all supported branches. Reported-by: lx zou <zoulx1982@163.com> Author: Fujii Masao Reviewed-by: Alvaro Herrera Discussion: https://postgr.es/m/16931-620d0f2fdc6108f1@postgresql.org
diff --git a/src/backend/access/transam/commit_ts.c b/src/backend/access/transam/commit_ts.c
@@ -1074,7 +1074,7 @@ commit_ts_redo(XLogReaderState *record)
 			subxids = NULL;
 
 		TransactionTreeSetCommitTsData(setts->mainxid, nsubxids, subxids,
-									   setts->timestamp, setts->nodeid, true);
+									   setts->timestamp, setts->nodeid, false);
 		if (subxids)
 			pfree(subxids);
 	}

Original file line number	Diff line number	Diff line change
`@@ -1074,7 +1074,7 @@ commit_ts_redo(XLogReaderState *record)`
`1074`	`1074`	`subxids = NULL;`
`1075`	`1075`
`1076`	`1076`	`TransactionTreeSetCommitTsData(setts->mainxid, nsubxids, subxids,`
`1077`		`- setts->timestamp, setts->nodeid, true);`
	`1077`	`+ setts->timestamp, setts->nodeid, false);`
`1078`	`1078`	`if (subxids)`
`1079`	`1079`	`pfree(subxids);`
`1080`	`1080`	`}`