Fix ancient bug in handling of to_char modifier 'TH', when used with HH.

hlinnaka · hlinnaka · commit 44886bd878a2 · 2009-07-06T19:11:39.000Z
In what seems like an oversight, we used to treat 'TH' the same as lowercase
'th', but only with HH/HH12.
diff --git a/src/backend/utils/adt/formatting.c b/src/backend/utils/adt/formatting.c
@@ -1,7 +1,7 @@
 /* -----------------------------------------------------------------------
  * formatting.c
  *
- * $PostgreSQL: pgsql/src/backend/utils/adt/formatting.c,v 1.158 2009/06/22 17:54:30 tgl Exp $
+ * $PostgreSQL: pgsql/src/backend/utils/adt/formatting.c,v 1.159 2009/07/06 19:11:39 heikki Exp $
  *
  *
  *	 Portions Copyright (c) 1999-2009, PostgreSQL Global Development Group
@@ -2094,7 +2094,7 @@ DCH_to_char(FormatNode *node, bool is_interval, TmToChar *in, char *out)
 						tm->tm_hour % (HOURS_PER_DAY / 2) == 0 ? 12 :
 						tm->tm_hour % (HOURS_PER_DAY / 2));
 				if (S_THth(n->suffix))
-					str_numth(s, s, 0);
+					str_numth(s, s, S_TH_TYPE(n->suffix));
 				s += strlen(s);
 				break;
 			case DCH_HH24:

Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,7 @@`
`1`	`1`	`/* -----------------------------------------------------------------------`
`2`	`2`	`* formatting.c`
`3`	`3`	`*`
`4`		`- * $PostgreSQL: pgsql/src/backend/utils/adt/formatting.c,v 1.158 2009/06/22 17:54:30 tgl Exp $`
	`4`	`+ * $PostgreSQL: pgsql/src/backend/utils/adt/formatting.c,v 1.159 2009/07/06 19:11:39 heikki Exp $`
`5`	`5`	`*`
`6`	`6`	`*`
`7`	`7`	`* Portions Copyright (c) 1999-2009, PostgreSQL Global Development Group`
`@@ -2094,7 +2094,7 @@ DCH_to_char(FormatNode node, bool is_interval, TmToChar in, char *out)`
`2094`	`2094`	`tm->tm_hour % (HOURS_PER_DAY / 2) == 0 ? 12 :`
`2095`	`2095`	`tm->tm_hour % (HOURS_PER_DAY / 2));`
`2096`	`2096`	`if (S_THth(n->suffix))`
`2097`		`- str_numth(s, s, 0);`
	`2097`	`+ str_numth(s, s, S_TH_TYPE(n->suffix));`
`2098`	`2098`	`s += strlen(s);`
`2099`	`2099`	`break;`
`2100`	`2100`	`case DCH_HH24:`