Make comments reflect that omission of SPI_gettypmod() is intentional.

nmisch · nmisch · commit 448fee2e238a · 2013-07-12T18:07:46.000-04:00
diff --git a/src/backend/executor/spi.c b/src/backend/executor/spi.c
@@ -940,6 +940,12 @@ SPI_gettype(TupleDesc tupdesc, int fnumber)
 	return result;
 }
 
+/*
+ * Get the data type OID for a column.
+ *
+ * There's nothing similar for typmod and typcollation.  The rare consumers
+ * thereof should inspect the TupleDesc directly.
+ */
 Oid
 SPI_gettypeid(TupleDesc tupdesc, int fnumber)
 {
diff --git a/src/pl/plpgsql/src/pl_exec.c b/src/pl/plpgsql/src/pl_exec.c
@@ -4446,7 +4446,6 @@ exec_eval_datum(PLpgSQL_execstate *estate,
 							 errmsg("record \"%s\" has no field \"%s\"",
 									rec->refname, recfield->fieldname)));
 				*typeid = SPI_gettypeid(rec->tupdesc, fno);
-				/* XXX there's no SPI_gettypmod, for some reason */
 				if (fno > 0)
 					*typetypmod = rec->tupdesc->attrs[fno - 1]->atttypmod;
 				else
@@ -4623,12 +4622,10 @@ exec_get_datum_type_info(PLpgSQL_execstate *estate,
 							 errmsg("record \"%s\" has no field \"%s\"",
 									rec->refname, recfield->fieldname)));
 				*typeid = SPI_gettypeid(rec->tupdesc, fno);
-				/* XXX there's no SPI_gettypmod, for some reason */
 				if (fno > 0)
 					*typmod = rec->tupdesc->attrs[fno - 1]->atttypmod;
 				else
 					*typmod = -1;
-				/* XXX there's no SPI_getcollation either */
 				if (fno > 0)
 					*collation = rec->tupdesc->attrs[fno - 1]->attcollation;
 				else	/* no system column types have collation */

Original file line number	Diff line number	Diff line change
`@@ -940,6 +940,12 @@ SPI_gettype(TupleDesc tupdesc, int fnumber)`
`940`	`940`	`return result;`
`941`	`941`	`}`
`942`	`942`
	`943`	`+/*`
	`944`	`+ * Get the data type OID for a column.`
	`945`	`+ *`
	`946`	`+ * There's nothing similar for typmod and typcollation. The rare consumers`
	`947`	`+ * thereof should inspect the TupleDesc directly.`
	`948`	`+ */`
`943`	`949`	`Oid`
`944`	`950`	`SPI_gettypeid(TupleDesc tupdesc, int fnumber)`
`945`	`951`	`{`